Re: [PATCH 1/5] mmc: mxcmmc: add mpc512x SDHC support

2013-03-14 Thread Arnd Bergmann
On Thursday 14 March 2013, Anatolij Gustschin wrote: > I wanted to avoid additional levels of indirection and function calls > on i.MX. If something like > > static inline u32 mxcmci_readl(struct mxcmci_host *host, int reg) > { > #if IS_ENABLED(CONFIG_PPC_MPC512x) > return in_be32(host->ba

Re: [PATCH 1/5] mmc: mxcmmc: add mpc512x SDHC support

2013-03-14 Thread Sascha Hauer
On Thu, Mar 14, 2013 at 07:13:32PM +0100, Anatolij Gustschin wrote: > On Thu, 14 Mar 2013 17:50:08 +0100 > Arnd Bergmann wrote: > > > On Thursday 14 March 2013 17:40:49 Anatolij Gustschin wrote: > > > > > + > > > +struct mxcmci_reg_ops mxcmci_reg_ops = { > > > + .read_l = mpcmci_readl, > > > + .

Re: [PATCH 1/5] mmc: mxcmmc: add mpc512x SDHC support

2013-03-14 Thread Anatolij Gustschin
On Thu, 14 Mar 2013 17:50:08 +0100 Arnd Bergmann wrote: > On Thursday 14 March 2013 17:40:49 Anatolij Gustschin wrote: > > > + > > +struct mxcmci_reg_ops mxcmci_reg_ops = { > > + .read_l = mpcmci_readl, > > + .write_l = mpcmci_writel, > > + .read_w = mpcmci_readw, > > + .write_w = mpcmci

Re: [PATCH 1/5] mmc: mxcmmc: add mpc512x SDHC support

2013-03-14 Thread Arnd Bergmann
On Thursday 14 March 2013 17:40:49 Anatolij Gustschin wrote: > + > +struct mxcmci_reg_ops mxcmci_reg_ops = { > + .read_l = mpcmci_readl, > + .write_l = mpcmci_writel, > + .read_w = mpcmci_readw, > + .write_w = mpcmci_writew, > +}; > +#else > +struct mxcmci_reg_ops mxcmci_reg_ops; >

[PATCH 1/5] mmc: mxcmmc: add mpc512x SDHC support

2013-03-14 Thread Anatolij Gustschin
The SDHC controller on mpc512x is compatible with i.MX31 SDHC, so the mxcmmc driver can be used on mpc512x, too. Extend the driver to support mpc512x as well. Signed-off-by: Anatolij Gustschin --- drivers/mmc/host/Kconfig | 10 +- drivers/mmc/host/mxcmmc.c | 222 +