[PATCH 1/5] mmc: sdhci-esdhc-imx: add support for write protect on custom GPIO

2011-02-23 Thread Wolfram Sang
Signed-off-by: Wolfram Sang Tested-by: Marc Reilly Tested-by: Eric Benard --- change since last version: * improve kerneldoc arch/arm/plat-mxc/include/mach/esdhc.h | 10 +- drivers/mmc/host/sdhci-esdhc-imx.c | 52 +--- 2 files changed, 50 insertions(+)

[PATCH 1/5] mmc: sdhci-esdhc-imx: add support for write protect on custom GPIO

2011-02-22 Thread Wolfram Sang
Signed-off-by: Wolfram Sang Tested-by: Marc Reilly --- Change since last version: * rewrote the warning message to apply to non-existant wp_gpio arch/arm/plat-mxc/include/mach/esdhc.h | 10 +- drivers/mmc/host/sdhci-esdhc-imx.c | 52 +--- 2 files change

Re: [PATCH 1/5] mmc: sdhci-esdhc-imx: add support for write protect on custom GPIO

2011-02-11 Thread Wolfram Sang
Marc, On Fri, Feb 11, 2011 at 09:24:38AM +1100, Marc Reilly wrote: > Tested-by: Marc Reilly Thanks a lot! > > + if (boarddata) { > > Perhaps (boarddata && gpio_is_valid(boarddata->wp_gpio) as above? > > For example what if someone sets up the boarddata for a card detect, but not > write

Re: [PATCH 1/5] mmc: sdhci-esdhc-imx: add support for write protect on custom GPIO

2011-02-10 Thread Marc Reilly
Hi Wolfram, First three patches work well on my vpr200 board (mx35). One comment inline... I ran some tests of insert/remove card with the card locked and unlocked, and trying to append a file. It behaved as expected, thus: Tested-by: Marc Reilly > +static unsigned int esdhc_pltfm_get_ro(s

[PATCH 1/5] mmc: sdhci-esdhc-imx: add support for write protect on custom GPIO

2011-02-10 Thread Wolfram Sang
Signed-off-by: Wolfram Sang --- arch/arm/plat-mxc/include/mach/esdhc.h | 10 +- drivers/mmc/host/sdhci-esdhc-imx.c | 51 +--- 2 files changed, 49 insertions(+), 12 deletions(-) diff --git a/arch/arm/plat-mxc/include/mach/esdhc.h b/arch/arm/plat-mxc/includ