[PATCH 1/6] mmc: sdhci-pltfm: Add structure for host-specific data

2010-10-15 Thread Wolfram Sang
We need to carry some information per host, e.g. the clock. Add a structure for it and initialize it in the generic part. Also improve the check for a parent. Signed-off-by: Wolfram Sang Cc: Richard Röjfors --- drivers/mmc/host/sdhci-pltfm.c | 10 +++--- drivers/mmc/host/sdhci-pltfm.h |

[PATCH 1/6] mmc: sdhci-pltfm: Add structure for host-specific data

2010-10-11 Thread Wolfram Sang
We need to carry some information per host, e.g. the clock. Add a structure for it and initialize it in the generic part. Also improve the check for a parent. Signed-off-by: Wolfram Sang Cc: Richard Röjfors --- Changes since last version: * Improved detection of a "real" parent device driver

Re: [PATCH 1/6] mmc: sdhci-pltfm: Add structure for host-specific data

2010-09-30 Thread Anton Vorontsov
On Thu, Sep 30, 2010 at 12:19:38PM +0200, Wolfram Sang wrote: [...] > > You're right it wouldn't. But isn't it a bit risky even if you could access > > it, > > in the long the platform_data coild point to something that is in the > > __devinit section > > or similar? > > The use-case we see now

Re: [PATCH 1/6] mmc: sdhci-pltfm: Add structure for host-specific data

2010-09-30 Thread Wolfram Sang
On Thu, Sep 30, 2010 at 11:54:53AM +0200, Richard Röjfors wrote: > On 09/30/2010 10:16 AM, Wolfram Sang wrote: > >Hi Richard, > > > >On Wed, Sep 29, 2010 at 11:24:25PM +0200, Richard Röjfors wrote: > >>On 09/29/2010 10:07 PM, Wolfram Sang wrote: > >>>We need to carry some information per host, e.g.

Re: [PATCH 1/6] mmc: sdhci-pltfm: Add structure for host-specific data

2010-09-30 Thread Richard Röjfors
On 09/30/2010 10:16 AM, Wolfram Sang wrote: Hi Richard, On Wed, Sep 29, 2010 at 11:24:25PM +0200, Richard Röjfors wrote: On 09/29/2010 10:07 PM, Wolfram Sang wrote: We need to carry some information per host, e.g. the clock. Add a structure for it and initialize it in the generic part. Also do

Re: [PATCH 1/6] mmc: sdhci-pltfm: Add structure for host-specific data

2010-09-30 Thread Wolfram Sang
Hi Richard, On Wed, Sep 29, 2010 at 11:24:25PM +0200, Richard Röjfors wrote: > On 09/29/2010 10:07 PM, Wolfram Sang wrote: > >We need to carry some information per host, e.g. the clock. Add a > >structure for it and initialize it in the generic part. Also do not use > >the parent of the platform_d

Re: [PATCH 1/6] mmc: sdhci-pltfm: Add structure for host-specific data

2010-09-29 Thread Richard Röjfors
On 09/29/2010 10:07 PM, Wolfram Sang wrote: We need to carry some information per host, e.g. the clock. Add a structure for it and initialize it in the generic part. Also do not use the parent of the platform_device (if it is available), this breaks the clock-matching on ARM. The reason it's th

[PATCH 1/6] mmc: sdhci-pltfm: Add structure for host-specific data

2010-09-29 Thread Wolfram Sang
We need to carry some information per host, e.g. the clock. Add a structure for it and initialize it in the generic part. Also do not use the parent of the platform_device (if it is available), this breaks the clock-matching on ARM. Signed-off-by: Wolfram Sang Cc: Richard Röjfors --- Changes si

Re: [PATCH 1/6] mmc: sdhci-pltfm: Add structure for host-specific data

2010-09-28 Thread Wolfram Sang
On Tue, Sep 28, 2010 at 06:54:47AM -0700, Philip Rakity wrote: > taking this off line for a bit (if you don't mind) Actually, I do. Going back to the list. > I really like what you are doing but it does not go far enough. The > controller I work on is somewhat funny and broken. It needs to do

Re: [PATCH 1/6] mmc: sdhci-pltfm: Add structure for host-specific data

2010-09-28 Thread zhangfei gao
On Tue, Sep 28, 2010 at 8:36 AM, Wolfram Sang wrote: > We need to carry some information per host, e.g. the clock. Add a > structure for it and initialize it in the generic part. > > Signed-off-by: Wolfram Sang > --- > > Change since last version: > > * include clk.h > >  drivers/mmc/host/sdhci-p

Re: [PATCH 1/6] mmc: sdhci-pltfm: Add structure for host-specific data

2010-09-28 Thread Anton Vorontsov
On Tue, Sep 28, 2010 at 02:36:41PM +0200, Wolfram Sang wrote: > We need to carry some information per host, e.g. the clock. Add a > structure for it and initialize it in the generic part. > > Signed-off-by: Wolfram Sang > --- [...] > +++ b/drivers/mmc/host/sdhci-pltfm.h > @@ -11,8 +11,14 @@ > #i

[PATCH 1/6] mmc: sdhci-pltfm: Add structure for host-specific data

2010-09-28 Thread Wolfram Sang
We need to carry some information per host, e.g. the clock. Add a structure for it and initialize it in the generic part. Signed-off-by: Wolfram Sang --- Change since last version: * include clk.h drivers/mmc/host/sdhci-pltfm.c |7 +-- drivers/mmc/host/sdhci-pltfm.h |6 ++ 2 f