Re: [PATCH 1/7] mmc: at91_mci: fix pointer errors

2010-08-30 Thread Wolfgang Mües
Hi, Am 29.08.2010 23:39, schrieb Ryan Mallon: I see this is already applied, but why all the type trickery here? Why not just: memcpy(dmabuf, sgbuffer, amount); dmabuf += amount / sizeof(dmabuf); Because this is wrong? Maybe you mean sizeof(*dmabuf)? The exact style of the b

Re: [PATCH 1/7] mmc: at91_mci: fix pointer errors

2010-08-30 Thread Wolfgang Mües
Hi, Am 27.08.2010 21:34, schrieb Chris Ball: On Fri, Aug 27, 2010 at 08:33:03PM +0100, Chris Ball wrote: Looks like only the first half of this patch was applied? The kunmap_atomic() line is still present as before in Linus' tree. It was argued that the kunmap_atomic() will truncate the poin

Re: [PATCH 1/7] mmc: at91_mci: fix pointer errors

2010-08-30 Thread Ryan Mallon
Wolfgang Mües wrote: > Hi, > > Am 29.08.2010 23:39, schrieb Ryan Mallon: >> I see this is already applied, but why all the type trickery here? Why >> not just: >> >> memcpy(dmabuf, sgbuffer, amount); >> dmabuf += amount / sizeof(dmabuf); > > Because this is wrong? > > Maybe you mean size

Re: [PATCH 1/7] mmc: at91_mci: fix pointer errors

2010-08-29 Thread Ryan Mallon
On 08/28/2010 07:33 AM, Chris Ball wrote: > Hi Andrew, Nicolas, > > On Fri, Feb 26, 2010 at 07:39:29PM +0100, Nicolas Ferre wrote: >> From: Wolfgang Muees >> >> Fixes two pointer errors, one which leads to memory overwrites if used with >> large chunks of data. >> >> Signed-off-by: Wolfgang Muees

Re: [PATCH 1/7] mmc: at91_mci: fix pointer errors

2010-08-27 Thread Chris Ball
On Fri, Aug 27, 2010 at 08:33:03PM +0100, Chris Ball wrote: > Looks like only the first half of this patch was applied? The > kunmap_atomic() line is still present as before in Linus' tree. Might be related to Dan Carpenter's suggestion that the spacing for that line should change to: k

Re: [PATCH 1/7] mmc: at91_mci: fix pointer errors

2010-08-27 Thread Chris Ball
Hi Andrew, Nicolas, On Fri, Feb 26, 2010 at 07:39:29PM +0100, Nicolas Ferre wrote: > From: Wolfgang Muees > > Fixes two pointer errors, one which leads to memory overwrites if used with > large chunks of data. > > Signed-off-by: Wolfgang Muees > Signed-off-by: Nicolas Ferre > --- > drivers/m

Re: [PATCH 1/7] mmc: at91_mci: fix pointer errors

2010-02-26 Thread Dan Carpenter
On Fri, Feb 26, 2010 at 07:39:29PM +0100, Nicolas Ferre wrote: > From: Wolfgang Muees > > Fixes two pointer errors, one which leads to memory overwrites if used with > large chunks of data. > > Signed-off-by: Wolfgang Muees > Signed-off-by: Nicolas Ferre > --- > drivers/mmc/host/at91_mci.c |

[PATCH 1/7] mmc: at91_mci: fix pointer errors

2010-02-26 Thread Nicolas Ferre
From: Wolfgang Muees Fixes two pointer errors, one which leads to memory overwrites if used with large chunks of data. Signed-off-by: Wolfgang Muees Signed-off-by: Nicolas Ferre --- drivers/mmc/host/at91_mci.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/dri