Re: [PATCH 13/29] mmc: tmio: add regulator support

2012-05-18 Thread Guennadi Liakhovetski
On Thu, 3 May 2012, Mark Brown wrote: On Thu, May 03, 2012 at 05:05:42PM +0200, Guennadi Liakhovetski wrote: +static void tmio_mmc_set_power(struct tmio_mmc_host *host, struct mmc_ios *ios) +{ + if (!(host-mmc-caps MMC_CAP_POWER_OFF_CARD)) + return; + + if

Re: [PATCH 13/29] mmc: tmio: add regulator support

2012-05-18 Thread Mark Brown
On Fri, May 18, 2012 at 11:55:53AM +0200, Guennadi Liakhovetski wrote: On Thu, 3 May 2012, Mark Brown wrote: should it be being factored out into the core? Wll, it's not a lot of code. We could make this a library function, provided by the core, but I don't think it would be very

[PATCH 13/29] mmc: tmio: add regulator support

2012-05-03 Thread Guennadi Liakhovetski
Currently the TMIO MMC driver derives the OCR mask from the platform data and uses a platform callback to turn card power on and off. This patch adds regulator support to the driver. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de Cc: Mark Brown broo...@opensource.wolfsonmicro.com ---

Re: [PATCH 13/29] mmc: tmio: add regulator support

2012-05-03 Thread Mark Brown
On Thu, May 03, 2012 at 05:05:42PM +0200, Guennadi Liakhovetski wrote: +static void tmio_mmc_set_power(struct tmio_mmc_host *host, struct mmc_ios *ios) +{ + if (!(host-mmc-caps MMC_CAP_POWER_OFF_CARD)) + return; + + if (host-vdd) + /* Errors ignored... */