Re: [PATCH 2/2] mmc: Remove dead code

2012-05-09 Thread Chris Ball
Hi, On Wed, Apr 11 2012, Philippe De Swert wrote: > bus_width is passed to the function and when 0 (MMC_BUS_WIDTH_1) > will cause the function to return. So in in the second test it > definitly is different from 0, and the third test is redundant. > > Signed-off-by: Philippe De Swert > --- > dr

Re: [PATCH 2/2] mmc: Remove dead code

2012-05-09 Thread Namjae Jeon
Hi. Chris. Would you check this patch also ? Thanks. 2012/4/12, Namjae Jeon : > 2012/4/12 Philippe De Swert : >> bus_width is passed to the function and when 0 (MMC_BUS_WIDTH_1) >> will cause the function to return. So in in the second test it >> definitly is different from 0, and the third test

Re: [PATCH 2/2] mmc: Remove dead code

2012-04-11 Thread Namjae Jeon
2012/4/12 Philippe De Swert : > bus_width is passed to the function and when 0 (MMC_BUS_WIDTH_1) > will cause the function to return. So in in the second test it > definitly is different from 0, and the third test is redundant. > > Signed-off-by: Philippe De Swert > --- Looks good to me. Reviewed-

Re: [PATCH 2/2] mmc: Remove dead code

2012-04-11 Thread Philip Rakity
Acked-by: Philip Rakity On Apr 11, 2012, at 1:32 PM, Philippe De Swert wrote: > bus_width is passed to the function and when 0 (MMC_BUS_WIDTH_1) > will cause the function to return. So in in the second test it > definitly is different from 0, and the third test is redundant. > > Signed-off-by

[PATCH 2/2] mmc: Remove dead code

2012-04-11 Thread Philippe De Swert
bus_width is passed to the function and when 0 (MMC_BUS_WIDTH_1) will cause the function to return. So in in the second test it definitly is different from 0, and the third test is redundant. Signed-off-by: Philippe De Swert --- drivers/mmc/core/mmc.c |6 +- 1 file changed, 1 insertion(