Re: [PATCH 2/2] mmc: esdhc: add quirk to support 3.3v for T4240

2015-06-05 Thread Ulf Hansson
[...] But the operation will make host-ocr_mask to have no use for other voltage supporting. I think using | instead or just assigning host-ocr_mask to ocr_avail should be ok. If so, there is no need to add this quirk. This is kind of a policy change for how to treat the configuration

Re: [PATCH 2/2] mmc: esdhc: add quirk to support 3.3v for T4240

2015-06-05 Thread Ulf Hansson
[...] Actually the sdhci-of-esdhc driver would set host-ocr_mask when it probes. mmc_of_parse_voltage(np, host-ocr_mask); Okay, got it - thanks! So I tried to understand when the voltage-range binding should be used, but the DT documentation is quite poor for it. Anyway, I assumes the

Re: [PATCH 2/2] mmc: esdhc: add quirk to support 3.3v for T4240

2015-06-05 Thread Ulf Hansson
; Chris Ball Subject: Re: [PATCH 2/2] mmc: esdhc: add quirk to support 3.3v for T4240 On 2 June 2015 at 09:09, Yangbo Lu yangbo...@freescale.com wrote: Add SDHCI_QUIRK2_CIRCUIT_SUPPORT_VS33 for T4240 Signed-off-by: Yangbo Lu yangbo...@freescale.com --- drivers/mmc/host/sdhci

Re: [PATCH 2/2] mmc: esdhc: add quirk to support 3.3v for T4240

2015-06-04 Thread Ulf Hansson
On 2 June 2015 at 09:09, Yangbo Lu yangbo...@freescale.com wrote: Add SDHCI_QUIRK2_CIRCUIT_SUPPORT_VS33 for T4240 Signed-off-by: Yangbo Lu yangbo...@freescale.com --- drivers/mmc/host/sdhci-of-esdhc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mmc/host/sdhci-of-esdhc.c

Re: [PATCH 2/2] mmc: esdhc: add quirk to support 3.3v for T4240

2015-06-04 Thread Ulf Hansson
: add quirk to support 3.3v for T4240 On 2 June 2015 at 09:09, Yangbo Lu yangbo...@freescale.com wrote: Add SDHCI_QUIRK2_CIRCUIT_SUPPORT_VS33 for T4240 Signed-off-by: Yangbo Lu yangbo...@freescale.com --- drivers/mmc/host/sdhci-of-esdhc.c | 3 +++ 1 file changed, 3 insertions

[PATCH 2/2] mmc: esdhc: add quirk to support 3.3v for T4240

2015-06-02 Thread Yangbo Lu
Add SDHCI_QUIRK2_CIRCUIT_SUPPORT_VS33 for T4240 Signed-off-by: Yangbo Lu yangbo...@freescale.com --- drivers/mmc/host/sdhci-of-esdhc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c index 22e9111..4f5fe42 100644 ---