Re: [PATCH 2/3] mmc: add MMC_QUIRK_BROKEN_CLK_GATING

2011-01-10 Thread Philip Rakity
On Jan 10, 2011, at 8:57 AM, Pierre Tardy wrote: >> >> >> Since the code is not called that often could you change the above code to: >> >>> if (mmc_card_sdio(card)) >>> return !(card->quirks & MMC_QUIRK_BROKEN_CLK_GATING); > Well, The comment in the >>return true;

Re: [PATCH 2/3] mmc: add MMC_QUIRK_BROKEN_CLK_GATING

2011-01-10 Thread Pierre Tardy
> > > Since the code is not called that often could you change the above code to: > >>       if (mmc_card_sdio(card)) >>               return !(card->quirks & MMC_QUIRK_BROKEN_CLK_GATING); Well, The comment in the >        return true; > > more obvious that quirk only applies to sdio. Disagree.Act

Re: [PATCH 2/3] mmc: add MMC_QUIRK_BROKEN_CLK_GATING

2011-01-10 Thread Philip Rakity
On Jan 9, 2011, at 8:26 AM, Pierre Tardy wrote: > Some sdio card are not following sdio standard, and does not work > when the sdio bus's clock is gated > > To keep functionnality for all legacy driver, we turn this quirk on > for every sdio card. > Drivers needs to disable the quirk manually wh

[PATCH 2/3] mmc: add MMC_QUIRK_BROKEN_CLK_GATING

2011-01-09 Thread Pierre Tardy
Some sdio card are not following sdio standard, and does not work when the sdio bus's clock is gated To keep functionnality for all legacy driver, we turn this quirk on for every sdio card. Drivers needs to disable the quirk manually when someone verified that their supported card works with clock