Re: [PATCH 2/3] mmc: protect against clockgate races

2010-11-17 Thread Chris Ball
Hi Linus, On Tue, Nov 16, 2010 at 05:56:52PM +0100, Linus Walleij wrote: > This adds a mutex to protect from races between gate and ungate > calls colliding. > > Cc: Ohad Ben-Cohen > Signed-off-by: Linus Walleij Thanks, merged into mmc-next for .38. -- Chris Ball On

Re: [PATCH 2/3] mmc: protect against clockgate races

2010-11-17 Thread Linus Walleij
2010/11/16 David Vrabel : > Linus Walleij wrote: >> This adds a mutex to protect from races between gate and ungate >> calls colliding. > > Can you rework this to not require both host->clk_gate_mutex and > host->clk_lock?  Is host->clk_lock necessary any more? No I can't. I really wanted to, and

Re: [PATCH 2/3] mmc: protect against clockgate races

2010-11-16 Thread David Vrabel
Linus Walleij wrote: > This adds a mutex to protect from races between gate and ungate > calls colliding. Can you rework this to not require both host->clk_gate_mutex and host->clk_lock? Is host->clk_lock necessary any more? David > Cc: Ohad Ben-Cohen > Signed-off-by: Linus Walleij > --- > Th

[PATCH 2/3] mmc: protect against clockgate races

2010-11-16 Thread Linus Walleij
This adds a mutex to protect from races between gate and ungate calls colliding. Cc: Ohad Ben-Cohen Signed-off-by: Linus Walleij --- This should fix the race observed by Ohad earlier. --- drivers/mmc/core/host.c | 11 --- include/linux/mmc/host.h |1 + 2 files changed, 9 insertio