Re: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23

2012-09-17 Thread Chris Ball
Hi, On Thu, Sep 13 2012, Kumar Gala wrote: Can you list out which SoCs support it and which don't. Having this list will be useful in understanding which controller versions supported it. P1020, p1021, p1022, p1024, p1015 and p4080 can't support it. Mpc8536, p2020, and the other current

Re: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23

2012-09-17 Thread Kumar Gala
On Sep 17, 2012, at 7:36 AM, Chris Ball wrote: Hi, On Thu, Sep 13 2012, Kumar Gala wrote: Can you list out which SoCs support it and which don't. Having this list will be useful in understanding which controller versions supported it. P1020, p1021, p1022, p1024, p1015 and p4080 can't

Re: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23

2012-09-17 Thread Chris Ball
Hi, On Mon, Sep 17 2012, Kumar Gala wrote: P1020, p1021, p1022, p1024, p1015 and p4080 can't support it. Mpc8536, p2020, and the other current DPAA silicon (e.g. p5020, p3041) support it. Based on this, why don't we use the HOSTVER register to detect instead of device tree: I've got a

Re: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23

2012-09-17 Thread Kumar Gala
On Sep 17, 2012, at 8:09 PM, Huang Changming-R66093 wrote: On Sep 17, 2012, at 7:36 AM, Chris Ball wrote: Hi, On Thu, Sep 13 2012, Kumar Gala wrote: Can you list out which SoCs support it and which don't. Having this list will be useful in understanding which controller versions

Re: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23

2012-09-17 Thread Chris Ball
Hi, On Tue, Sep 18 2012, Kumar Gala wrote: I've got a mild preference for handling quirk assignment in the DT rather than in driver code, so I'd prefer to just push the original patch to mmc-next as-is. Does that sound okay? Why? I only ask because I agree with Scott that this means you

Re: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23

2012-09-14 Thread Kumar Gala
-Original Message- From: Chris Ball [mailto:c...@laptop.org] Sent: Wednesday, September 12, 2012 4:59 AM To: Kumar Gala Cc: Huang Changming-R66093; linuxppc-...@lists.ozlabs.org list; linux- m...@vger.kernel.org; Anton Vorontsov Subject: Re: [PATCH 2/3] powerpc/esdhc: add property

RE: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23

2012-09-13 Thread Huang Changming-R66093
] powerpc/esdhc: add property to disable the CMD23 On Wed, Sep 12, 2012 at 03:19:18AM +, Huang Changming-R66093 wrote: [...] I don't think it is the best way to do it. For the VVN2.2 or older, some silicon support this feature (mpc8536 and p2020), but other silicones don't support it (e.g

Re: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23

2012-09-13 Thread Kumar Gala
Vorontsov Subject: Re: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23 Hi, On Tue, Sep 11 2012, Kumar Gala wrote: thanks for the info. Do you know what's required on controller side to handle cards that support CMD23? I'm trying to figure out if older controller's on FSL

RE: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23

2012-09-13 Thread Huang Changming-R66093
: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23 On Sep 12, 2012, at 9:02 PM, Huang Changming-R66093 wrote: -Original Message- From: Chris Ball [mailto:c...@laptop.org] Sent: Wednesday, September 12, 2012 4:59 AM To: Kumar Gala Cc: Huang Changming-R66093; linuxppc

RE: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23

2012-09-12 Thread Huang Changming-R66093
] powerpc/esdhc: add property to disable the CMD23 Hi, On Tue, Sep 11 2012, Kumar Gala wrote: thanks for the info. Do you know what's required on controller side to handle cards that support CMD23? I'm trying to figure out if older controller's on FSL SoCs are missing some feature

Re: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23

2012-09-12 Thread Kumar Gala
- m...@vger.kernel.org; Anton Vorontsov Subject: Re: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23 Hi, On Tue, Sep 11 2012, Kumar Gala wrote: thanks for the info. Do you know what's required on controller side to handle cards that support CMD23? I'm trying to figure out

RE: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23

2012-09-12 Thread Huang Changming-R66093
-Original Message- From: Chris Ball [mailto:c...@laptop.org] Sent: Wednesday, September 12, 2012 4:59 AM To: Kumar Gala Cc: Huang Changming-R66093; linuxppc-...@lists.ozlabs.org list; linux- m...@vger.kernel.org; Anton Vorontsov Subject: Re: [PATCH 2/3] powerpc/esdhc: add

[PATCH 2/3] powerpc/esdhc: add property to disable the CMD23

2012-09-11 Thread Chang-Ming.Huang
From: Jerry Huang chang-ming.hu...@freescale.com Below SOCs don't support the cmd23 command for MMC card, therefore, disable it in device tree: P1020, P1021, P1022, P1024, P1025 and P4080 Signed-off-by: Jerry Huang chang-ming.hu...@freescale.com CC: Anton Vorontsov cbouatmai...@gmail.com ---

Re: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23

2012-09-11 Thread Anton Vorontsov
On Tue, Sep 11, 2012 at 03:12:44PM +0800, chang-ming.hu...@freescale.com wrote: From: Jerry Huang chang-ming.hu...@freescale.com Below SOCs don't support the cmd23 command for MMC card, therefore, disable it in device tree: P1020, P1021, P1022, P1024, P1025 and P4080 Signed-off-by: Jerry

Re: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23

2012-09-11 Thread Anton Vorontsov
On Tue, Sep 11, 2012 at 12:54:29AM -0700, Anton Vorontsov wrote: On Tue, Sep 11, 2012 at 03:12:44PM +0800, chang-ming.hu...@freescale.com wrote: From: Jerry Huang chang-ming.hu...@freescale.com Below SOCs don't support the cmd23 command for MMC card, therefore, disable it in device

RE: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23

2012-09-11 Thread Huang Changming-R66093
@vger.kernel.org; Kumar Gala; linuxppc-...@lists.ozlabs.org Subject: Re: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23 On Tue, Sep 11, 2012 at 12:54:29AM -0700, Anton Vorontsov wrote: On Tue, Sep 11, 2012 at 03:12:44PM +0800, Chang- ming.hu...@freescale.com wrote: From: Jerry Huang

Re: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23

2012-09-11 Thread Kumar Gala
: Re: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23 On Tue, Sep 11, 2012 at 12:54:29AM -0700, Anton Vorontsov wrote: On Tue, Sep 11, 2012 at 03:12:44PM +0800, Chang- ming.hu...@freescale.com wrote: From: Jerry Huang chang-ming.hu...@freescale.com Below SOCs don't support

Re: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23

2012-09-11 Thread Kumar Gala
In sdhci_add_host() We have the following ... mmc-caps |= MMC_CAP_SDIO_IRQ | MMC_CAP_ERASE | MMC_CAP_CMD23; if (host-quirks SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12) host-flags |= SDHCI_AUTO_CMD12; /* Auto-CMD23 stuff only works in ADMA or PIO. */ if

Re: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23

2012-09-11 Thread Chris Ball
Hi, On Tue, Sep 11 2012, Kumar Gala wrote: In sdhci_add_host() We have the following ... mmc-caps |= MMC_CAP_SDIO_IRQ | MMC_CAP_ERASE | MMC_CAP_CMD23; if (host-quirks SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12) host-flags |= SDHCI_AUTO_CMD12; /*

Re: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23

2012-09-11 Thread Scott Wood
On 09/11/2012 03:04 AM, Anton Vorontsov wrote: On Tue, Sep 11, 2012 at 12:54:29AM -0700, Anton Vorontsov wrote: On Tue, Sep 11, 2012 at 03:12:44PM +0800, chang-ming.hu...@freescale.com wrote: From: Jerry Huang chang-ming.hu...@freescale.com Below SOCs don't support the cmd23 command for MMC

Re: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23

2012-09-11 Thread Kumar Gala
On Sep 11, 2012, at 9:44 AM, Chris Ball wrote: Hi, On Tue, Sep 11 2012, Kumar Gala wrote: In sdhci_add_host() We have the following ... mmc-caps |= MMC_CAP_SDIO_IRQ | MMC_CAP_ERASE | MMC_CAP_CMD23; if (host-quirks SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12)

Re: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23

2012-09-11 Thread Chris Ball
Hi, On Tue, Sep 11 2012, Kumar Gala wrote: thanks for the info. Do you know what's required on controller side to handle cards that support CMD23? I'm trying to figure out if older controller's on FSL SoCs are missing some feature to allow CMD23 to work (vs Auto-CMD23). It seems plausible

RE: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23

2012-09-11 Thread Huang Changming-R66093
Best Regards Jerry Huang -Original Message- From: Wood Scott-B07421 Sent: Wednesday, September 12, 2012 2:28 AM To: Anton Vorontsov Cc: Huang Changming-R66093; linuxppc-...@lists.ozlabs.org; linux- m...@vger.kernel.org Subject: Re: [PATCH 2/3] powerpc/esdhc: add property

Re: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23

2012-09-11 Thread Anton Vorontsov
On Wed, Sep 12, 2012 at 03:19:18AM +, Huang Changming-R66093 wrote: [...] I don't think it is the best way to do it. For the VVN2.2 or older, some silicon support this feature (mpc8536 and p2020), but other silicones don't support it (e.g. p4080, p102x). Though, the current p5/p4/p3 has