On 4 June 2014 13:42, Ben Dooks wrote:
> Start tidying the probe/release code by using devm_ioremap_resource() to
> map the IO registers.
>
> Signed-off-by: Ben Dooks
Signed-off-by: Ulf Hansson
> ---
> Fixes from v1:
> - return the PTR_ERR() from devm_ioremap
> - remove error p
Start tidying the probe/release code by using devm_ioremap_resource() to
map the IO registers.
Signed-off-by: Ben Dooks
---
Fixes from v1:
- return the PTR_ERR() from devm_ioremap
- remove error print as it already shows an error
---
drivers/mmc/host/sh_mmcif.c | 24 ++---
Hello.
On 01-04-2014 14:25, Ben Dooks wrote:
Start tidying the probe/release code by using devm_ioremap_resource() to
map the IO registers.
Signed-off-by: Ben Dooks
---
drivers/mmc/host/sh_mmcif.c | 20 +---
1 file changed, 5 insertions(+), 15 deletions(-)
diff --git a
Hi Ben,
Thank you for the patch.
On Tuesday 01 April 2014 11:25:50 Ben Dooks wrote:
> Start tidying the probe/release code by using devm_ioremap_resource() to
> map the IO registers.
>
> Signed-off-by: Ben Dooks
> ---
> drivers/mmc/host/sh_mmcif.c | 20 +---
> 1 file changed, 5
On 01/04/14 11:55, Geert Uytterhoeven wrote:
On Tue, Apr 1, 2014 at 12:25 PM, Ben Dooks wrote:
+ reg = devm_ioremap_resource(&pdev->dev, res);
+ if (IS_ERR(reg)) {
dev_err(&pdev->dev, "ioremap error.\n");
devm_ioremap_resource() already calls dev_err() for the var
On Tue, Apr 1, 2014 at 12:25 PM, Ben Dooks wrote:
> + reg = devm_ioremap_resource(&pdev->dev, res);
> + if (IS_ERR(reg)) {
> dev_err(&pdev->dev, "ioremap error.\n");
devm_ioremap_resource() already calls dev_err() for the various error
cases, so you can drop this line.
Start tidying the probe/release code by using devm_ioremap_resource() to
map the IO registers.
Signed-off-by: Ben Dooks
---
drivers/mmc/host/sh_mmcif.c | 20 +---
1 file changed, 5 insertions(+), 15 deletions(-)
diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmci
