Re: [PATCH 2/7] mmc: Don't use PF_MEMALLOC

2009-11-18 Thread Minchan Kim
On Wed, Nov 18, 2009 at 7:54 PM, Peter Zijlstra wrote: > On Wed, 2009-11-18 at 19:31 +0900, Minchan Kim wrote: >> > >> > Sure some generic blocklevel infrastructure might work, _but_ you cannot >> > take away the responsibility of determining the amount of memory needed, >> > nor does any of this

Re: [PATCH 2/7] mmc: Don't use PF_MEMALLOC

2009-11-18 Thread Peter Zijlstra
On Wed, 2009-11-18 at 19:31 +0900, Minchan Kim wrote: > > > > Sure some generic blocklevel infrastructure might work, _but_ you cannot > > take away the responsibility of determining the amount of memory needed, > > nor does any of this have any merit if you do not limit yourself to that > > amount

Re: [PATCH 2/7] mmc: Don't use PF_MEMALLOC

2009-11-18 Thread Minchan Kim
On Wed, Nov 18, 2009 at 6:56 PM, Peter Zijlstra wrote: > On Wed, 2009-11-18 at 09:01 +0900, Minchan Kim wrote: >> Hi, Peter. >> >> First of all, Thanks for the commenting. >> >> On Wed, Nov 18, 2009 at 5:47 AM, Peter Zijlstra wrote: >> > On Tue, 2009-11-17 at 21:51 +0900, Minchan Kim wrote: >> >>

Re: [PATCH 2/7] mmc: Don't use PF_MEMALLOC

2009-11-18 Thread Peter Zijlstra
On Wed, 2009-11-18 at 09:01 +0900, Minchan Kim wrote: > Hi, Peter. > > First of all, Thanks for the commenting. > > On Wed, Nov 18, 2009 at 5:47 AM, Peter Zijlstra wrote: > > On Tue, 2009-11-17 at 21:51 +0900, Minchan Kim wrote: > >> I think it's because mempool reserves memory. > >> (# of I/O i

Re: [PATCH 2/7] mmc: Don't use PF_MEMALLOC

2009-11-17 Thread Minchan Kim
Hi, Peter. First of all, Thanks for the commenting. On Wed, Nov 18, 2009 at 5:47 AM, Peter Zijlstra wrote: > On Tue, 2009-11-17 at 21:51 +0900, Minchan Kim wrote: >> I think it's because mempool reserves memory. >> (# of I/O issue\0 is hard to be expected. >> How do we determine mempool size of

Re: [PATCH 2/7] mmc: Don't use PF_MEMALLOC

2009-11-17 Thread Peter Zijlstra
On Tue, 2009-11-17 at 21:51 +0900, Minchan Kim wrote: > I think it's because mempool reserves memory. > (# of I/O issue\0 is hard to be expected. > How do we determine mempool size of each block driver? > For example, maybe, server use few I/O for nand. > but embedded system uses a lot of I/O.

Re: [PATCH 2/7] mmc: Don't use PF_MEMALLOC

2009-11-17 Thread Minchan Kim
Sorry for the noise. While I am typing, my mail client already send the mail. :(. This is genuine. KOSAKI Motohiro wrote: >> On Tue, 17 Nov 2009 16:17:50 +0900 (JST) >> KOSAKI Motohiro wrote: >> >>> Non MM subsystem must not use PF_MEMALLOC. Memory reclaim need few >>> memory, anyone must not pr

Re: [PATCH 2/7] mmc: Don't use PF_MEMALLOC

2009-11-17 Thread KOSAKI Motohiro
> On Tue, 17 Nov 2009 16:17:50 +0900 (JST) > KOSAKI Motohiro wrote: > > > Non MM subsystem must not use PF_MEMALLOC. Memory reclaim need few > > memory, anyone must not prevent it. Otherwise the system cause > > mysterious hang-up and/or OOM Killer invokation. > > So now what happens if we are p

Re: [PATCH 2/7] mmc: Don't use PF_MEMALLOC

2009-11-17 Thread Oliver Neukum
Am Dienstag, 17. November 2009 11:32:36 schrieb Minchan Kim: > On Tue, Nov 17, 2009 at 7:29 PM, Alan Cox wrote: > > On Tue, 17 Nov 2009 16:17:50 +0900 (JST) > > > > KOSAKI Motohiro wrote: > >> Non MM subsystem must not use PF_MEMALLOC. Memory reclaim need few > >> memory, anyone must not prevent

Re: [PATCH 2/7] mmc: Don't use PF_MEMALLOC

2009-11-17 Thread Minchan Kim
On Tue, Nov 17, 2009 at 7:29 PM, Alan Cox wrote: > On Tue, 17 Nov 2009 16:17:50 +0900 (JST) > KOSAKI Motohiro wrote: > >> Non MM subsystem must not use PF_MEMALLOC. Memory reclaim need few >> memory, anyone must not prevent it. Otherwise the system cause >> mysterious hang-up and/or OOM Killer in

Re: [PATCH 2/7] mmc: Don't use PF_MEMALLOC

2009-11-17 Thread Alan Cox
On Tue, 17 Nov 2009 16:17:50 +0900 (JST) KOSAKI Motohiro wrote: > Non MM subsystem must not use PF_MEMALLOC. Memory reclaim need few > memory, anyone must not prevent it. Otherwise the system cause > mysterious hang-up and/or OOM Killer invokation. So now what happens if we are paging and all ou

[PATCH 2/7] mmc: Don't use PF_MEMALLOC

2009-11-16 Thread KOSAKI Motohiro
Non MM subsystem must not use PF_MEMALLOC. Memory reclaim need few memory, anyone must not prevent it. Otherwise the system cause mysterious hang-up and/or OOM Killer invokation. Cc: linux-mmc@vger.kernel.org Signed-off-by: KOSAKI Motohiro --- drivers/mmc/card/queue.c |2 -- 1 files changed,