On 9 January 2015 at 10:44, Kuninori Morimoto
wrote:
>
> Hi Arnd, Ulf
>
>> > Hmm... indeed Arnd's patch and my patch-set conflicts.
>> > I have these patch / patch-set
>> > 1) header cleanup for tmio
>> > 2) slave_id cleanup for shdma
>> > 3) add DMA feature for sh_mobile_sdhi
>> >
>> > 1 ) and
Hi Arnd, Ulf
> > Hmm... indeed Arnd's patch and my patch-set conflicts.
> > I have these patch / patch-set
> > 1) header cleanup for tmio
> > 2) slave_id cleanup for shdma
> > 3) add DMA feature for sh_mobile_sdhi
> >
> > 1 ) and 2) conflicts here. one idea is like this
> > 1) header cleanup
On Thursday 08 January 2015 07:30:36 Kuninori Morimoto wrote:
>
> Hmm... indeed Arnd's patch and my patch-set conflicts.
> I have these patch / patch-set
> 1) header cleanup for tmio
> 2) slave_id cleanup for shdma
> 3) add DMA feature for sh_mobile_sdhi
>
> 1 ) and 2) conflicts here. one idea
Hi Arnd, Ulf
> > > > dmaengine: shdma: use normal interface for passing slave id
> > > >
> > > > The shmobile platform is one of only two users of the slave_id field
> > > > in dma_slave_config, which is incompatible with the way that the
> > > > dmaengine API normally works.
> > > >
> > > > I'
Hi Arnd
> > > dmaengine: shdma: use normal interface for passing slave id
> > >
> > > The shmobile platform is one of only two users of the slave_id field
> > > in dma_slave_config, which is incompatible with the way that the
> > > dmaengine API normally works.
> > >
> > > I've had a closer loo
On Wednesday 07 January 2015 02:28:43 Kuninori Morimoto wrote:
>
> Hi Arnd
>
> Thank you for your DMAEngine fixup patch.
> I tried this patch, and have comment.
Thanks for looking at the changes
> >
> > - sdev = to_shdma_dev(schan->dma_chan.device);
> > - ret = sdev->ops->set_slave(schan,
On Wednesday 07 January 2015 03:01:22 Kuninori Morimoto wrote:
> Hi Arnd
>
> > dmaengine: shdma: use normal interface for passing slave id
> >
> > The shmobile platform is one of only two users of the slave_id field
> > in dma_slave_config, which is incompatible with the way that the
> > dmaengin
Hi Arnd
> dmaengine: shdma: use normal interface for passing slave id
>
> The shmobile platform is one of only two users of the slave_id field
> in dma_slave_config, which is incompatible with the way that the
> dmaengine API normally works.
>
> I've had a closer look at the existing code now a
Hi Arnd, Ulf
> > > > > The alignment_shift and dma_rx_offset values seem to always be
> > > > > the same for all users (at least the remaining ones, possibly there
> > > > > were others originally), so you could hardcode those in tmio_mmc_dma.c
> > > > > and remove the tmio_mmc_dma structure enti
Hi Arnd
Thank you for your DMAEngine fixup patch.
I tried this patch, and have comment.
> dmaengine: shdma: use normal interface for passing slave id
>
> The shmobile platform is one of only two users of the slave_id field
> in dma_slave_config, which is incompatible with the way that the
> dma
Hi Arnd, Ulf
Thank you for your feedback
> > Then, I want to try "dmaengine cleanup" patch-set as 2nd step if possible.
> > I guess [8/9] and [9/9] are not good for "header cleanup" (?) I don't know.
> > Arnd, Ulf, what is your opinion ?
>
> Patch 8 looks great to me.
>
> Patch 9 as I mentione
On Tuesday 06 January 2015 00:20:59 Kuninori Morimoto wrote:
>
> Hi Arnd, Ulf
>
> Thank you for your feedback
>
> > > > The slave_id/chan_priv values are now passed three times into the
> > > > driver, and one should really be enough. I'd suggest removing the
> > > > integer fields from both tmi
On Tuesday 06 January 2015 02:38:53 Kuninori Morimoto wrote:
> Hi Arnd again
>
> > > > The alignment_shift and dma_rx_offset values seem to always be
> > > > the same for all users (at least the remaining ones, possibly there
> > > > were others originally), so you could hardcode those in tmio_mmc
Hi Arnd again
> > > The alignment_shift and dma_rx_offset values seem to always be
> > > the same for all users (at least the remaining ones, possibly there
> > > were others originally), so you could hardcode those in tmio_mmc_dma.c
> > > and remove the tmio_mmc_dma structure entirely.
> >
> >
Hi Arnd, Ulf
Thank you for your feedback
> > > The slave_id/chan_priv values are now passed three times into the
> > > driver, and one should really be enough. I'd suggest removing the
> > > integer fields from both tmio_mmc_dma and tmio_mmc_data (added in
> > > patch 9), and instead pass it as
On Monday 05 January 2015 09:35:16 Kuninori Morimoto wrote:
>
> Hi Arnd
>
> Thank you for your review
>
> > > diff --git a/drivers/mmc/host/tmio_mmc.h b/drivers/mmc/host/tmio_mmc.h
> > > index 3d02a3c1..4c5eda8 100644
> > > --- a/drivers/mmc/host/tmio_mmc.h
> > > +++ b/drivers/mmc/host/tmio_mmc.
Hi Arnd
Thank you for your review
> > diff --git a/drivers/mmc/host/tmio_mmc.h b/drivers/mmc/host/tmio_mmc.h
> > index 3d02a3c1..4c5eda8 100644
> > --- a/drivers/mmc/host/tmio_mmc.h
> > +++ b/drivers/mmc/host/tmio_mmc.h
> > @@ -40,6 +40,16 @@
> >
> > struct tmio_mmc_data;
> >
> > +struct tm
On Monday 05 January 2015 07:02:41 Kuninori Morimoto wrote:
> From: Kuninori Morimoto
>
> Current .dma is implemented under tmio_mmc_data.
> It goes to tmio_mmc_host by this patch.
>
> Signed-off-by: Kuninori Morimoto
The patch looks good, just like the rest of the series, but there is
one asp
From: Kuninori Morimoto
Current .dma is implemented under tmio_mmc_data.
It goes to tmio_mmc_host by this patch.
Signed-off-by: Kuninori Morimoto
---
drivers/mmc/host/sh_mobile_sdhi.c |4 ++--
drivers/mmc/host/tmio_mmc.h | 11 +++
drivers/mmc/host/tmio_mmc_dma.c | 24 ++
19 matches
Mail list logo
