Re: [PATCH 3/3] mmc: add sdhci-tegra driver for Tegra SoCs

2010-12-23 Thread Olof Johansson
Hi, On Wed, Dec 22, 2010 at 10:20 PM, Mike Rapoport m...@compulab.co.il wrote: Only one comment below, otherwise feel free to add Acked-by: Mike Rapoport m...@compulab.co.il Thanks! +     if (gpio_is_valid(plat-wp_gpio)) { +             rc = gpio_request(plat-wp_gpio, sdhci_wp); +        

[PATCH 3/3] mmc: add sdhci-tegra driver for Tegra SoCs

2010-12-22 Thread Olof Johansson
SDHCI driver for Tegra. Pretty straight forward, a few pieces of functionality left to fill in but nothing that stops it from going upstream. Board enablement submitted separately. This driver plugs in as a new variant of sdhci-pltfm, using the platform data structure passed in to specify the

Re: [PATCH 3/3] mmc: add sdhci-tegra driver for Tegra SoCs

2010-12-22 Thread Wolfram Sang
Hi Olof, looks good to me. Just some minor comments, but in general Reviewed-by: Wolfram Sang w.s...@pengutronix.de On Wed, Dec 22, 2010 at 02:01:11AM -0600, Olof Johansson wrote: SDHCI driver for Tegra. Pretty straight forward, a few pieces of functionality left to fill in but nothing that

Re: [PATCH 3/3] mmc: add sdhci-tegra driver for Tegra SoCs

2010-12-22 Thread Olof Johansson
Hi, Thanks for the review. All good points (and I forgot to do a last run through checkpatch, my bad). All have been addressed in the next version (not yet posted). -Olof On Wed, Dec 22, 2010 at 8:22 AM, Wolfram Sang w.s...@pengutronix.de wrote: Hi Olof, looks good to me. Just some minor

Re: [PATCH 3/3] mmc: add sdhci-tegra driver for Tegra SoCs

2010-12-22 Thread Mike Rapoport
On 12/22/10 10:01, Olof Johansson wrote: SDHCI driver for Tegra. Pretty straight forward, a few pieces of functionality left to fill in but nothing that stops it from going upstream. Board enablement submitted separately. This driver plugs in as a new variant of sdhci-pltfm, using the