Re: [PATCH 3/3 RESEND] mmc: sdhci: check voltage range only on regulators aware of voltage value

2013-02-20 Thread Kevin Liu
2013/2/14 Ulf Hansson ulf.hans...@linaro.org: On 14 February 2013 09:05, Marek Szyprowski m.szyprow...@samsung.com wrote: On 2/13/2013 12:35 PM, Mark Brown wrote: On Wed, Feb 13, 2013 at 08:45:56AM +0100, Guennadi Liakhovetski wrote: On Wed, 13 Feb 2013, Marek Szyprowski wrote: BTW,

Re: [PATCH 3/3 RESEND] mmc: sdhci: check voltage range only on regulators aware of voltage value

2013-02-14 Thread Marek Szyprowski
On 2/13/2013 12:35 PM, Mark Brown wrote: On Wed, Feb 13, 2013 at 08:45:56AM +0100, Guennadi Liakhovetski wrote: On Wed, 13 Feb 2013, Marek Szyprowski wrote: BTW, mmc_regulator_get_ocrmask() won't work with continuous range regulators. This seems like a problem, that has to be fixed...

Re: [PATCH 3/3 RESEND] mmc: sdhci: check voltage range only on regulators aware of voltage value

2013-02-14 Thread Mark Brown
On Thu, Feb 14, 2013 at 09:05:43AM +0100, Marek Szyprowski wrote: 1. mmc_regulator_get_ocrmask() works only with regulators which support regulator_count_voltages() and regulator_list_voltage(). Recently support for continuous regulators have been merged. Such regulators doesn't provide

Re: [PATCH 3/3 RESEND] mmc: sdhci: check voltage range only on regulators aware of voltage value

2013-02-14 Thread Ulf Hansson
On 14 February 2013 09:05, Marek Szyprowski m.szyprow...@samsung.com wrote: On 2/13/2013 12:35 PM, Mark Brown wrote: On Wed, Feb 13, 2013 at 08:45:56AM +0100, Guennadi Liakhovetski wrote: On Wed, 13 Feb 2013, Marek Szyprowski wrote: BTW, mmc_regulator_get_ocrmask() won't work with

Re: [PATCH 3/3 RESEND] mmc: sdhci: check voltage range only on regulators aware of voltage value

2013-02-13 Thread Mark Brown
On Wed, Feb 13, 2013 at 08:45:56AM +0100, Guennadi Liakhovetski wrote: On Wed, 13 Feb 2013, Marek Szyprowski wrote: BTW, mmc_regulator_get_ocrmask() won't work with continuous range regulators. This seems like a problem, that has to be fixed... Indeed, what's the issue? signature.asc

[PATCH 3/3 RESEND] mmc: sdhci: check voltage range only on regulators aware of voltage value

2013-02-12 Thread Marek Szyprowski
Some regulators don't report any voltage values, so checking supported voltage range results in disabling all SDHCI_CAN_VDD_* flags and registration failure. This patch finally provides a correct fix for the registration of SDHCI driver with all possible voltage regulators: dummy, fixed and

Re: [PATCH 3/3 RESEND] mmc: sdhci: check voltage range only on regulators aware of voltage value

2013-02-12 Thread Guennadi Liakhovetski
Hi Marek On Tue, 12 Feb 2013, Marek Szyprowski wrote: Some regulators don't report any voltage values, so checking supported voltage range results in disabling all SDHCI_CAN_VDD_* flags and registration failure. This patch finally provides a correct fix for the registration of SDHCI driver

Re: [PATCH 3/3 RESEND] mmc: sdhci: check voltage range only on regulators aware of voltage value

2013-02-12 Thread Marek Szyprowski
Hello, On 2/12/2013 11:10 PM, Guennadi Liakhovetski wrote: Hi Marek On Tue, 12 Feb 2013, Marek Szyprowski wrote: Some regulators don't report any voltage values, so checking supported voltage range results in disabling all SDHCI_CAN_VDD_* flags and registration failure. This patch finally

Re: [PATCH 3/3 RESEND] mmc: sdhci: check voltage range only on regulators aware of voltage value

2013-02-12 Thread Guennadi Liakhovetski
On Wed, 13 Feb 2013, Marek Szyprowski wrote: Hello, On 2/12/2013 11:10 PM, Guennadi Liakhovetski wrote: Hi Marek On Tue, 12 Feb 2013, Marek Szyprowski wrote: Some regulators don't report any voltage values, so checking supported voltage range results in disabling all