Re: [PATCH 3/4] mmc: host: sdhci-tegra: cleanup ifdefs

2013-03-06 Thread Stephen Warren
On 02/20/2013 11:35 AM, Rhyland Klein wrote: The structs wrapped with the SOC ifdefs are small enough where having them always there shouldn't be a big overhead. Removing the ifdefs also makes the code a little cleaner. Chris, I think patches 3 and 4 of this series can go through either the

Re: [PATCH 3/4] mmc: host: sdhci-tegra: cleanup ifdefs

2013-03-06 Thread Chris Ball
Hi, On Wed, Mar 06 2013, Stephen Warren wrote: On 02/20/2013 11:35 AM, Rhyland Klein wrote: The structs wrapped with the SOC ifdefs are small enough where having them always there shouldn't be a big overhead. Removing the ifdefs also makes the code a little cleaner. I think patches 3 and 4

Re: [PATCH 3/4] mmc: host: sdhci-tegra: cleanup ifdefs

2013-03-06 Thread Stephen Warren
On 03/06/2013 03:54 PM, Chris Ball wrote: Hi, On Wed, Mar 06 2013, Stephen Warren wrote: On 02/20/2013 11:35 AM, Rhyland Klein wrote: The structs wrapped with the SOC ifdefs are small enough where having them always there shouldn't be a big overhead. Removing the ifdefs also makes the code

Re: [PATCH 3/4] mmc: host: sdhci-tegra: cleanup ifdefs

2013-03-06 Thread Chris Ball
Hi, On Wed, Mar 06 2013, Stephen Warren wrote: Via the MMC tree with an ack sounds good OK, thanks. Patches 3/4 and 4/4, Acked-by: Stephen Warren swar...@nvidia.com Thanks, both pushed out to mmc-next for 3.10 now. - Chris. -- Chris Ball c...@laptop.org http://printf.net/ One Laptop

[PATCH 3/4] mmc: host: sdhci-tegra: cleanup ifdefs

2013-02-20 Thread Rhyland Klein
The structs wrapped with the SOC ifdefs are small enough where having them always there shouldn't be a big overhead. Removing the ifdefs also makes the code a little cleaner. Signed-off-by: Rhyland Klein rkl...@nvidia.com --- drivers/mmc/host/sdhci-tegra.c |8 1 file changed, 8

Re: [PATCH 3/4] mmc: host: sdhci-tegra: cleanup ifdefs

2013-02-20 Thread Stephen Warren
On 02/20/2013 11:35 AM, Rhyland Klein wrote: The structs wrapped with the SOC ifdefs are small enough where having them always there shouldn't be a big overhead. Removing the ifdefs also makes the code a little cleaner. Patch 3 and 4 to the MMC driver look fine. But I'd ask Chris to hold off