Re: [PATCH 3/4] mmc: omap_hsmmc: Remux pins to support SDIO interrupt and PM runtime

2013-06-14 Thread Tony Lindgren
* Tony Lindgren [130612 06:27]: > * Linus Walleij [130611 01:00]: > > If we can agree on this I will add the active state to the > > state table and add a container in the core for this as well > > as pinctrl_pm_select_active_state() so we can skip all the > > pointless boilerplate also in the OM

Re: [PATCH 3/4] mmc: omap_hsmmc: Remux pins to support SDIO interrupt and PM runtime

2013-06-12 Thread Tony Lindgren
* Linus Walleij [130611 01:00]: > On Mon, Jun 10, 2013 at 6:23 PM, Tony Lindgren wrote: > > > We only should remux the pins that need remuxing as that's done > > every time hitting idle. So I think we should have the following > > default groups: > > > > default Static pins that don't ch

Re: [PATCH 3/4] mmc: omap_hsmmc: Remux pins to support SDIO interrupt and PM runtime

2013-06-11 Thread Linus Walleij
On Mon, Jun 10, 2013 at 6:23 PM, Tony Lindgren wrote: > We only should remux the pins that need remuxing as that's done > every time hitting idle. So I think we should have the following > default groups: > > default Static pins that don't change, no need to remux > config

Re: [PATCH 3/4] mmc: omap_hsmmc: Remux pins to support SDIO interrupt and PM runtime

2013-06-10 Thread Tony Lindgren
* Linus Walleij [130610 09:09]: > > You can use the new infrastructure to make the core select: > > pinctrl_pm_select_default_state(host->dev); > pinctrl_pm_select_idle_state(host->dev); OK great. > What is the semantic difference between "default" and "active"? We only should remux the pins

Re: [PATCH 3/4] mmc: omap_hsmmc: Remux pins to support SDIO interrupt and PM runtime

2013-06-10 Thread Linus Walleij
On Fri, Jun 7, 2013 at 11:49 PM, Tony Lindgren wrote: > On some omaps we need to remux MMC pins for PM, and for some omaps > we need to remux the SDIO IRQ pin. > > Based on an earlier patch by Andreas Fenkart . (...) > + host->pinctrl = devm_pinctrl_get(host->dev); > + if (IS_ERR(host

[PATCH 3/4] mmc: omap_hsmmc: Remux pins to support SDIO interrupt and PM runtime

2013-06-07 Thread Tony Lindgren
On some omaps we need to remux MMC pins for PM, and for some omaps we need to remux the SDIO IRQ pin. Based on an earlier patch by Andreas Fenkart . Cc: Andreas Fenkart Cc: Balaji T K Cc: Linus Walleij Signed-off-by: Tony Lindgren --- drivers/mmc/host/omap_hsmmc.c | 93