RE: [PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect the card

2012-11-18 Thread Huang Changming-R66093
rnel.org > Subject: Re: [PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect > the card > > On Mon, Nov 19, 2012 at 03:15:53AM +, Huang Changming-R66093 wrote: > [...] > > > > > @@ -1573,6 +1573,26 @@ static int sdhci_get_ro(st

Re: [PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect the card

2012-11-18 Thread Anton Vorontsov
On Mon, Nov 19, 2012 at 03:15:53AM +, Huang Changming-R66093 wrote: [...] > > > > @@ -1573,6 +1573,26 @@ static int sdhci_get_ro(struct mmc_host *mmc) > > > > return ret; > > > > } > > > > > > > > +/* Return values for the sdjco_get_cd callback: > > > > + * 0 for a absent card > > >

RE: [PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect the card

2012-11-18 Thread Huang Changming-R66093
> -Original Message- > From: Anton Vorontsov [mailto:cbouatmai...@gmail.com] > Sent: Monday, November 19, 2012 10:58 AM > To: Huang Changming-R66093 > Cc: Chris Ball; linux-mmc@vger.kernel.org > Subject: Re: [PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect >

Re: [PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect the card

2012-11-18 Thread Anton Vorontsov
On Mon, Nov 19, 2012 at 02:50:18AM +, Huang Changming-R66093 wrote: [...] > > diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index > > f05a377..cc9c8a6 100644 > > --- a/drivers/mmc/host/sdhci.c > > +++ b/drivers/mmc/host/sdhci.c > > @@ -1573,6 +1573,26 @@ static int sdhci_get_

RE: [PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect the card

2012-11-18 Thread Huang Changming-R66093
sov; Chris Ball > Subject: [PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect the > card > > From: Jerry Huang > > Add callback function sdhci_get_cd to detect the card. > And one new callback added to implement the card detect in sdhci > struncture. > If special

[PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect the card

2012-10-30 Thread r66093
From: Jerry Huang Add callback function sdhci_get_cd to detect the card. And one new callback added to implement the card detect in sdhci struncture. If special platform has the card detect callback, it will return the card state, the value zero is for absent cardi and one is for present card. If

RE: [PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect the card

2012-01-12 Thread Huang Changming-R66093
> -Original Message- > From: Aaron Lu [mailto:aaron...@amd.com] > Sent: Friday, January 13, 2012 2:21 PM > To: Huang Changming-R66093 > Cc: linux-mmc@vger.kernel.org; Chris Ball > Subject: Re: [PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect > the card >

Re: [PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect the card

2012-01-12 Thread Aaron Lu
On Fri, Jan 13, 2012 at 04:50:11AM +, Huang Changming-R66093 wrote: > > > > I think this function has to take care of standard sd host behaviour: if > > a specific host has implemented the get_cd callback, then use it; if > > not, then see the BROKEN_DETECT quirk; finally, use the present reg

RE: [PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect the card

2012-01-12 Thread Huang Changming-R66093
> -Original Message- > From: Aaron Lu [mailto:aaron...@amd.com] > Sent: Friday, January 13, 2012 11:27 AM > To: Huang Changming-R66093 > Cc: linux-mmc@vger.kernel.org; Chris Ball > Subject: Re: [PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect > the card >

Re: [PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect the card

2012-01-12 Thread Aaron Lu
> Sent: Wednesday, December 14, 2011 10:18 AM > > To: linux-mmc@vger.kernel.org > > Cc: Huang Changming-R66093; Chris Ball > > Subject: [PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect the > > card > > > > From: Jerry Huang > > > > A

RE: [PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect the card

2012-01-12 Thread Huang Changming-R66093
Ball > Subject: [PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect the > card > > From: Jerry Huang > > Add callback function sdhci_get_cd to detect the card. > And one new callback added to implement the card detect in sdhci > struncture. > If special platform has th

RE: [PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect the card

2011-12-15 Thread Huang Changming-R66093
ris Ball > Subject: Re: [PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect > the card > > On 12/16/2011 12:25 PM, Huang Changming-R66093 wrote: > > >>> I am very confused, why do we read the present state register on > every > >> request? > >&g

Re: [PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect the card

2011-12-15 Thread Jaehoon Chung
On 12/16/2011 12:25 PM, Huang Changming-R66093 wrote: >>> I am very confused, why do we read the present state register on every >> request? >> >> How long time read the present state register? > Even if one line code is performed, I think it need time to complete. > >>> My codes are added to the

RE: [PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect the card

2011-12-15 Thread Huang Changming-R66093
> > I am very confused, why do we read the present state register on every > request? > > How long time read the present state register? Even if one line code is performed, I think it need time to complete. > > My codes are added to the function mmc_sd_detect in file core/sd.c > > Function mmc_re

Re: [PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect the card

2011-12-15 Thread Jaehoon Chung
kity [mailto:prak...@marvell.com] >>>> Sent: Wednesday, December 14, 2011 12:52 PM >>>> To: Huang Changming-R66093 >>>> Cc: linux-mmc@vger.kernel.org; Huang Changming-R66093; Chris Ball >>>> Subject: Re: [PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to &

RE: [PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect the card

2011-12-14 Thread Huang Changming-R66093
> -Original Message- > From: Philip Rakity [mailto:prak...@marvell.com] > Sent: Thursday, December 15, 2011 2:42 PM > To: Huang Changming-R66093 > Cc: linux-mmc@vger.kernel.org; Chris Ball > Subject: Re: [PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect > th

Re: [PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect the card

2011-12-14 Thread Philip Rakity
; Huang Changming-R66093; Chris Ball >> Subject: Re: [PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect >> the card >> >> >> On Dec 13, 2011, at 6:18 PM, wrote: >> >>> From: Jerry Huang >>> >>> Add callback function sd

RE: [PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect the card

2011-12-14 Thread Huang Changming-R66093
> -Original Message- > From: Philip Rakity [mailto:prak...@marvell.com] > Sent: Wednesday, December 14, 2011 12:52 PM > To: Huang Changming-R66093 > Cc: linux-mmc@vger.kernel.org; Huang Changming-R66093; Chris Ball > Subject: Re: [PATCH 3/4 v5] SDHCI: add sdhci_get_cd

Re: [PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect the card

2011-12-13 Thread Philip Rakity
On Dec 13, 2011, at 6:18 PM, wrote: > From: Jerry Huang > > Add callback function sdhci_get_cd to detect the card. > And one new callback added to implement the card detect in sdhci struncture. > If special platform has the card detect callback, it will return the card > state, the value zero

[PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect the card

2011-12-13 Thread r66093
From: Jerry Huang Add callback function sdhci_get_cd to detect the card. And one new callback added to implement the card detect in sdhci struncture. If special platform has the card detect callback, it will return the card state, the value zero is for absent cardi and one is for present card. If