Re: [PATCH 3/5] mmc: sdhci: make sdhci-of device drivers self registered

2011-04-21 Thread Shawn Guo
On Tue, Apr 19, 2011 at 12:21:01PM +0200, Wolfram Sang wrote: +static int __devinit sdhci_esdhc_probe(struct platform_device *pdev) +{ + struct sdhci_host *host; + int ret; + + host = sdhci_pltfm_init(pdev, sdhci_esdhc_pdata); + if (!host) + return -ENOMEM;

Re: [PATCH 3/5] mmc: sdhci: make sdhci-of device drivers self registered

2011-04-19 Thread Wolfram Sang
+static int __devinit sdhci_esdhc_probe(struct platform_device *pdev) +{ + struct sdhci_host *host; + int ret; + + host = sdhci_pltfm_init(pdev, sdhci_esdhc_pdata); + if (!host) + return -ENOMEM; Just noticed: Since pltfm_init may fail due to various reasons,

Re: [PATCH 3/5] mmc: sdhci: make sdhci-of device drivers self registered

2011-03-31 Thread Grant Likely
On Fri, Mar 25, 2011 at 04:48:49PM +0800, Shawn Guo wrote: The patch turns the sdhci-of-core common stuff into helper functions added into sdhci-pltfm.c, and makes sdhci-of device drviers self registered using the same pair of .probe and .remove used by sdhci-pltfm device drivers. As a

[PATCH 3/5] mmc: sdhci: make sdhci-of device drivers self registered

2011-03-25 Thread Shawn Guo
The patch turns the sdhci-of-core common stuff into helper functions added into sdhci-pltfm.c, and makes sdhci-of device drviers self registered using the same pair of .probe and .remove used by sdhci-pltfm device drivers. As a result, sdhci-of-core.c and sdhci-of.h can be eliminated with those