Re: [PATCH 4/4] ARM: shmobile: ag5evm, ap4: Make use of irq index enum

2011-08-20 Thread Simon Horman
On Fri, Aug 19, 2011 at 09:52:17AM +0200, Guennadi Liakhovetski wrote: > On Fri, 19 Aug 2011, Simon Horman wrote: > > > On Fri, Aug 19, 2011 at 03:51:49PM +0900, Magnus Damm wrote: > > > On Fri, Aug 19, 2011 at 3:39 PM, Simon Horman wrote: > > [snip] > > > > > As we are already on the slippery

Re: [PATCH 4/4] ARM: shmobile: ag5evm, ap4: Make use of irq index enum

2011-08-20 Thread Guennadi Liakhovetski
On Fri, 19 Aug 2011, Simon Horman wrote: > On Fri, Aug 19, 2011 at 03:51:49PM +0900, Magnus Damm wrote: > > On Fri, Aug 19, 2011 at 3:39 PM, Simon Horman wrote: [snip] > > > As we are already on the slippery slope of allowing combinations > > > other than 1 (legacy) or 3 (specific) IRQ sources

Re: [PATCH 4/4] ARM: shmobile: ag5evm, ap4: Make use of irq index enum

2011-08-20 Thread Guennadi Liakhovetski
On Fri, 19 Aug 2011, Magnus Damm wrote: > On Fri, Aug 19, 2011 at 3:39 PM, Simon Horman wrote: [snip] > > As we are already on the slippery slope of allowing combinations > > other than 1 (legacy) or 3 (specific) IRQ sources I plan to implement > > a variant of your flag idea. The variation bei

Re: [PATCH 4/4] ARM: shmobile: ag5evm, ap4: Make use of irq index enum

2011-08-19 Thread Simon Horman
On Fri, Aug 19, 2011 at 03:51:49PM +0900, Magnus Damm wrote: > On Fri, Aug 19, 2011 at 3:39 PM, Simon Horman wrote: > > On Fri, Aug 19, 2011 at 02:20:11PM +0900, Simon Horman wrote: > >> On Fri, Aug 19, 2011 at 01:16:09PM +0900, Magnus Damm wrote: > >> > On Fri, Aug 19, 2011 at 10:10 AM, Simon Hor

Re: [PATCH 4/4] ARM: shmobile: ag5evm, ap4: Make use of irq index enum

2011-08-18 Thread Magnus Damm
On Fri, Aug 19, 2011 at 3:39 PM, Simon Horman wrote: > On Fri, Aug 19, 2011 at 02:20:11PM +0900, Simon Horman wrote: >> On Fri, Aug 19, 2011 at 01:16:09PM +0900, Magnus Damm wrote: >> > On Fri, Aug 19, 2011 at 10:10 AM, Simon Horman wrote: >> > > This is intended to make it easier to correctly or

Re: [PATCH 4/4] ARM: shmobile: ag5evm, ap4: Make use of irq index enum

2011-08-18 Thread Magnus Damm
On Fri, Aug 19, 2011 at 2:20 PM, Simon Horman wrote: ... > Moreover, I think that there needs to be some agreement between Guennadi > and yourself with regards to what IRQ combinations are valid before I (or > anyone else) can implement something that is acceptable to you both. And > I think that

Re: [PATCH 4/4] ARM: shmobile: ag5evm, ap4: Make use of irq index enum

2011-08-18 Thread Simon Horman
On Fri, Aug 19, 2011 at 02:20:11PM +0900, Simon Horman wrote: > On Fri, Aug 19, 2011 at 01:16:09PM +0900, Magnus Damm wrote: > > On Fri, Aug 19, 2011 at 10:10 AM, Simon Horman wrote: > > > This is intended to make it easier to correctly order IRQs. > > > > > > As suggested by Guennadi Liakhovetski

Re: [PATCH 4/4] ARM: shmobile: ag5evm, ap4: Make use of irq index enum

2011-08-18 Thread Simon Horman
On Fri, Aug 19, 2011 at 01:16:09PM +0900, Magnus Damm wrote: > On Fri, Aug 19, 2011 at 10:10 AM, Simon Horman wrote: > > This is intended to make it easier to correctly order IRQs. > > > > As suggested by Guennadi Liakhovetski. > > > --- a/arch/arm/mach-shmobile/board-ag5evm.c > > +++ b/arch/arm/

Re: [PATCH 4/4] ARM: shmobile: ag5evm, ap4: Make use of irq index enum

2011-08-18 Thread Magnus Damm
On Fri, Aug 19, 2011 at 10:10 AM, Simon Horman wrote: > This is intended to make it easier to correctly order IRQs. > > As suggested by Guennadi Liakhovetski. > --- a/arch/arm/mach-shmobile/board-ag5evm.c > +++ b/arch/arm/mach-shmobile/board-ag5evm.c > @@ -352,15 +352,15 @@ static struct resource

[PATCH 4/4] ARM: shmobile: ag5evm, ap4: Make use of irq index enum

2011-08-18 Thread Simon Horman
This is intended to make it easier to correctly order IRQs. As suggested by Guennadi Liakhovetski. Cc: Guennadi Liakhovetski Cc: Magnus Damm Cc: Paul Mundt Signed-off-by: Simon Horman --- Depends on "mmc: sdhi: Make use of per-source irq handlers" v4 * Update for corrected ordering of SH_M

[PATCH 4/4] ARM: shmobile: ag5evm, ap4: Make use of irq index enum

2011-08-17 Thread Simon Horman
This is intended to make it easier to correctly order IRQs. As suggested by Guennadi Liakhovetski. Cc: Guennadi Liakhovetski Cc: Magnus Damm Cc: Paul Mundt Signed-off-by: Simon Horman --- Depends on "mmc: sdhi: Make use of per-source irq handlers" v4 * Update for corrected ordering of SH_M

[PATCH 4/4] ARM: shmobile: ag5evm, ap4: Make use of irq index enum

2011-08-16 Thread Simon Horman
This is intended to make it easier to correctly order IRQs. As suggested by Guennadi Liakhovetski. Cc: Guennadi Liakhovetski Cc: Magnus Damm Cc: Paul Mundt Signed-off-by: Simon Horman --- Depends on "mmc: sdhi: Make use of per-source irq handlers" v4 * Update for corrected ordering of SH_M

Re: [PATCH 4/4] ARM: shmobile: ag5evm, ap4: Make use of irq index enum

2011-08-16 Thread Simon Horman
On Tue, Aug 16, 2011 at 08:36:20PM +0900, Simon Horman wrote: > On Tue, Aug 16, 2011 at 12:13:50PM +0100, Ben Dooks wrote: > > On Tue, Aug 16, 2011 at 07:11:26PM +0900, Simon Horman wrote: > > > This is intended to make it easier to correctly order IRQs. > > > > > > As suggested by Guennadi Liakho

Re: [PATCH 4/4] ARM: shmobile: ag5evm, ap4: Make use of irq index enum

2011-08-16 Thread Simon Horman
On Tue, Aug 16, 2011 at 12:13:50PM +0100, Ben Dooks wrote: > On Tue, Aug 16, 2011 at 07:11:26PM +0900, Simon Horman wrote: > > This is intended to make it easier to correctly order IRQs. > > > > As suggested by Guennadi Liakhovetski. > > > > Cc: Guennadi Liakhovetski > > Cc: Magnus Damm > > Sig

Re: [PATCH 4/4] ARM: shmobile: ag5evm, ap4: Make use of irq index enum

2011-08-16 Thread Ben Dooks
On Tue, Aug 16, 2011 at 07:11:26PM +0900, Simon Horman wrote: > This is intended to make it easier to correctly order IRQs. > > As suggested by Guennadi Liakhovetski. > > Cc: Guennadi Liakhovetski > Cc: Magnus Damm > Signed-off-by: Simon Horman > > --- > > Depends on "mmc: sdhi: Make use of

[PATCH 4/4] ARM: shmobile: ag5evm, ap4: Make use of irq index enum

2011-08-16 Thread Simon Horman
This is intended to make it easier to correctly order IRQs. As suggested by Guennadi Liakhovetski. Cc: Guennadi Liakhovetski Cc: Magnus Damm Signed-off-by: Simon Horman --- Depends on "mmc: sdhi: Make use of per-source irq handlers" --- arch/arm/mach-shmobile/board-ag5evm.c | 12 ++-