Re: [PATCH 4/7] mmc: at91_mci: use DMA buffer for read

2010-03-02 Thread Wolfgang Mües
Hi Andrew, Am Dienstag, 2. März 2010 schrieb Andrew Morton: > Nicolas Ferre wrote: > > + kunmap_atomic(((void *)sgbuffer)-sg->offset, KM_BIO_SRC_IRQ); > > It's a feature of kunmap_atomic() that it will accept a pointer to any > location in the page. So the subtraction isn't strictly n

Re: [PATCH 4/7] mmc: at91_mci: use DMA buffer for read

2010-03-02 Thread Andrew Morton
On Fri, 26 Feb 2010 19:39:32 +0100 Nicolas Ferre wrote: > + kunmap_atomic(((void *)sgbuffer)-sg->offset, KM_BIO_SRC_IRQ); It's a feature of kunmap_atomic() that it will accept a pointer to any location in the page. So the subtraction isn't strictly needed. And if the subtraction is

[PATCH 4/7] mmc: at91_mci: use DMA buffer for read

2010-02-26 Thread Nicolas Ferre
From: Wolfgang Muees This patch converts the read to use the DMA buffer as well. The old code was doing double-buffering DMA with the PDC; no way to make it work. Replace it with a single-PDC approach. It also simplify things removing the need for a pre_dma_read() function. Signed-off-by: Wolfga