On Tue, Oct 19, 2010 at 04:29:50AM +0200, Wolfram Sang wrote:
> > Stephen reports a -next build failure after this patch. Presumably this
> > should be sdhci-esdhc.h? It's confusing that no-one else hit this.
>
> Uh, ouch, one brown paper bag, please! Yeah, confusing, that is.
Ah, not that conf
Hi Chris,
> > -#define ESDHC_HOST_CONTROL_RES 0x05
> > +#include "sdhci-esdhc.c"
>
> Stephen reports a -next build failure after this patch. Presumably this
> should be sdhci-esdhc.h? It's confusing that no-one else hit this.
Uh, ouch, one brown paper bag, please! Yeah, confusing, that is.
Hi Wolfram,
On Fri, Oct 15, 2010 at 12:21:03PM +0200, Wolfram Sang wrote:
> diff --git a/drivers/mmc/host/sdhci-of-esdhc.c
> b/drivers/mmc/host/sdhci-of-esdhc.c
> index c8623de..277fcb9 100644
> --- a/drivers/mmc/host/sdhci-of-esdhc.c
> +++ b/drivers/mmc/host/sdhci-of-esdhc.c
> @@ -18,23 +18,7 @@
Put everything which can be shared between the OF and platform version
of this driver into a local .h-file.
Signed-off-by: Wolfram Sang
Tested-by : Eric Bénard
---
No change since last version. 80-char/line changes confirmed.
drivers/mmc/host/sdhci-esdhc.h| 83 ++
Put everything which can be shared between the OF and platform version
of this driver into a local .h-file.
Signed-off-by: Wolfram Sang
Tested-by : Eric Bénard
---
drivers/mmc/host/sdhci-esdhc.h| 81 +
drivers/mmc/host/sdhci-of-esdhc.c | 70 --
Put everything which can be shared between the OF and platform version
of this driver into a local .h-file.
Signed-off-by: Wolfram Sang
---
Changes since last version:
* use inline for set_clock()
drivers/mmc/host/sdhci-esdhc.h| 81 +
drivers/mmc/host
On Tue, Sep 28, 2010 at 02:36:45PM +0200, Wolfram Sang wrote:
> Put everything which can be shared between the OF and platform version
> of this driver into a local .h-file.
>
> Signed-off-by: Wolfram Sang
> ---
>
> Note: Anton suggested to move the function out of the .h-file into a seperate
>
Put everything which can be shared between the OF and platform version
of this driver into a local .h-file.
Signed-off-by: Wolfram Sang
---
Note: Anton suggested to move the function out of the .h-file into a seperate
.c-file. I tried this and it looked overly complicated to me; we ended up wit
