Re: [PATCH 6/7] mmc: core: protect references to host->areq with host->lock

2013-10-09 Thread Ulf Hansson
On 9 October 2013 02:48, Grant Grundler wrote: > Ulf, > While this patch might be correct, it's not solving the problem I > claimed and my explanation was wrong. See comments in this code > review: > https://chromium-review.googlesource.com/#/c/170880/1//COMMIT_MSG > > While I no longer see th

Re: [PATCH 6/7] mmc: core: protect references to host->areq with host->lock

2013-10-08 Thread Grant Grundler
Ulf, While this patch might be correct, it's not solving the problem I claimed and my explanation was wrong. See comments in this code review: https://chromium-review.googlesource.com/#/c/170880/1//COMMIT_MSG While I no longer see the same crash with this change in our "ToT tree", I'm able to

[PATCH 6/7] mmc: core: protect references to host->areq with host->lock

2013-09-26 Thread Grant Grundler
Races between host->areq being NULL or not are resulting in mmcqd hung_task panics. Like this one: <3>[ 240.501202] INFO: task mmcqd/1:85 blocked for more than 120 seconds. <3>[ 240.501213] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. <6>[ 240.501223] mmcqd/1