Re: [PATCH 7/14] drivers/mmc: Move dereference after NULL test

2009-10-19 Thread Uwe Kleine-König
On Sat, Oct 17, 2009 at 08:40:02AM +0200, Julia Lawall wrote: > From: Julia Lawall > > If the NULL test on mrq is needed, then the derefernce should be after the > NULL test. s/derefernce/dereference/ > A simplified version of the semantic match that detects this problem is as > follows (http:/

[PATCH 7/14] drivers/mmc: Move dereference after NULL test

2009-10-16 Thread Julia Lawall
From: Julia Lawall If the NULL test on mrq is needed, then the derefernce should be after the NULL test. A simplified version of the semantic match that detects this problem is as follows (http://coccinelle.lip6.fr/): // @match exists@ expression x, E; identifier fld; @@ * x->fld ... when !