On Fri, Apr 20, 2012 at 09:50:00AM -0700, Tony Lindgren wrote:
Then something like this is still needed on top of your original mmc driver
patch for omap2420:
--- a/drivers/mmc/host/omap.c
+++ b/drivers/mmc/host/omap.c
@@ -1617,11 +1617,14 @@ static int __init mmc_omap_probe(struct
* Russell King - ARM Linux li...@arm.linux.org.uk [120423 07:17]:
On Fri, Apr 20, 2012 at 09:50:00AM -0700, Tony Lindgren wrote:
Then something like this is still needed on top of your original mmc driver
patch for omap2420:
--- a/drivers/mmc/host/omap.c
+++ b/drivers/mmc/host/omap.c
* Russell King - ARM Linux li...@arm.linux.org.uk [120420 08:41]:
--- a/drivers/dma/omap-dma.c
+++ b/drivers/dma/omap-dma.c
@@ -83,11 +84,11 @@ static void omap_dma_start_sg(struct omap_chan *c, struct
omap_desc *d,
struct omap_sg *sg = d-sg + idx;
if (d-dir ==
* Russell King - ARM Linux li...@arm.linux.org.uk [120420 08:41]:
So, with this patch plus my original patch to omap's mmc host driver, this
should result in something which works without all the overhead of drivers
supplying the port information. Please confirm, and I'll merge this into
* Russell King - ARM Linux li...@arm.linux.org.uk [120420 15:13]:
On Fri, Apr 20, 2012 at 09:43:07AM -0700, Tony Lindgren wrote:
* Russell King - ARM Linux li...@arm.linux.org.uk [120420 08:41]:
--- a/drivers/dma/omap-dma.c
+++ b/drivers/dma/omap-dma.c
@@ -83,11 +84,11 @@ static void
On Wed, Apr 18, 2012 at 06:39:14PM -0700, Tony Lindgren wrote:
Cool, you almost got it. Got it working for n800 and 770 with the following
patch. Only extremely light testing done now so careful with this patch too..
Had to hack in support for the src_port and dst_port that's needed for
* Russell King - ARM Linux li...@arm.linux.org.uk [120419 10:46]:
On Wed, Apr 18, 2012 at 06:39:14PM -0700, Tony Lindgren wrote:
Cool, you almost got it. Got it working for n800 and 770 with the following
patch. Only extremely light testing done now so careful with this patch
too..
DMAengine uses the DMA engine device structure when mapping/unmapping
memory for DMA, so the MMC devices do not need their DMA masks
initialized (this reflects hardware: the MMC device is not the device
doing DMA.)
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
On Wed, Apr 18, 2012 at 3:42 PM, Russell King
rmk+ker...@arm.linux.org.uk wrote:
DMAengine uses the DMA engine device structure when mapping/unmapping
memory for DMA, so the MMC devices do not need their DMA masks
initialized (this reflects hardware: the MMC device is not the device
doing
On Wed, Apr 18, 2012 at 08:53:32PM +0530, T Krishnamoorthy, Balaji wrote:
Hi,
drivers/mmc/host/omap.c is also using dma_mask should that also be removed
Does this driver make use of this platform data?
If so, it needs converting to DMA engine _before_ this patch (which is
one reason why its
On Wed, Apr 18, 2012 at 8:59 PM, Russell King - ARM Linux
li...@arm.linux.org.uk wrote:
On Wed, Apr 18, 2012 at 08:53:32PM +0530, T Krishnamoorthy, Balaji wrote:
Hi,
drivers/mmc/host/omap.c is also using dma_mask should that also be removed
Does this driver make use of this platform data?
* T Krishnamoorthy, Balaji balaj...@ti.com [120418 08:39]:
On Wed, Apr 18, 2012 at 8:59 PM, Russell King - ARM Linux
li...@arm.linux.org.uk wrote:
On Wed, Apr 18, 2012 at 08:53:32PM +0530, T Krishnamoorthy, Balaji wrote:
Hi,
drivers/mmc/host/omap.c is also using dma_mask should that also
On Wed, Apr 18, 2012 at 11:19:18AM -0700, Tony Lindgren wrote:
* T Krishnamoorthy, Balaji balaj...@ti.com [120418 08:39]:
On Wed, Apr 18, 2012 at 8:59 PM, Russell King - ARM Linux
li...@arm.linux.org.uk wrote:
On Wed, Apr 18, 2012 at 08:53:32PM +0530, T Krishnamoorthy, Balaji wrote:
Hi,
On Wed, Apr 18, 2012 at 09:05:56PM +0530, T Krishnamoorthy, Balaji wrote:
On Wed, Apr 18, 2012 at 8:59 PM, Russell King - ARM Linux
li...@arm.linux.org.uk wrote:
On Wed, Apr 18, 2012 at 08:53:32PM +0530, T Krishnamoorthy, Balaji wrote:
Hi,
drivers/mmc/host/omap.c is also using dma_mask
* Russell King - ARM Linux li...@arm.linux.org.uk [120418 12:14]:
On Wed, Apr 18, 2012 at 11:19:18AM -0700, Tony Lindgren wrote:
* T Krishnamoorthy, Balaji balaj...@ti.com [120418 08:39]:
On Wed, Apr 18, 2012 at 8:59 PM, Russell King - ARM Linux
li...@arm.linux.org.uk wrote:
On Wed,
* Russell King - ARM Linux li...@arm.linux.org.uk [120418 12:46]:
On Wed, Apr 18, 2012 at 09:05:56PM +0530, T Krishnamoorthy, Balaji wrote:
On Wed, Apr 18, 2012 at 8:59 PM, Russell King - ARM Linux
li...@arm.linux.org.uk wrote:
On Wed, Apr 18, 2012 at 08:53:32PM +0530, T Krishnamoorthy,
On Wed, Apr 18, 2012 at 01:02:15PM -0700, Tony Lindgren wrote:
The scatterlist entries are separate DMA requests on omap1, there's no
chaining support in the DMA hardware on omap1. So yes, it's for every
scatterlist entry on omap1.
There's no direct scatterlist support on OMAP2 either
* Russell King - ARM Linux li...@arm.linux.org.uk [120418 13:28]:
On Wed, Apr 18, 2012 at 01:02:15PM -0700, Tony Lindgren wrote:
The scatterlist entries are separate DMA requests on omap1, there's no
chaining support in the DMA hardware on omap1. So yes, it's for every
scatterlist entry on
On Wed, Apr 18, 2012 at 02:01:44PM -0700, Tony Lindgren wrote:
* Russell King - ARM Linux li...@arm.linux.org.uk [120418 13:28]:
I'd like to have the same thing happen on OMAP1 as well (it's actually
quite simple to do) and it means that this DMA engine implementation
detail is (correctly)
* Russell King - ARM Linux li...@arm.linux.org.uk [120418 14:19]:
On Wed, Apr 18, 2012 at 02:01:44PM -0700, Tony Lindgren wrote:
* Russell King - ARM Linux li...@arm.linux.org.uk [120418 13:28]:
I'd like to have the same thing happen on OMAP1 as well (it's actually
quite simple to do) and
On Wed, Apr 18, 2012 at 10:16:06PM +0100, Russell King - ARM Linux wrote:
I don't think it has to in this case, though I am thinking that we
may have to adjust the frame size for other peripherals.
In the case of the OMAP1 MMC driver, let me pull out that chunk of code
again:
* Russell King - ARM Linux li...@arm.linux.org.uk [120418 14:40]:
On Wed, Apr 18, 2012 at 10:16:06PM +0100, Russell King - ARM Linux wrote:
I don't think it has to in this case, though I am thinking that we
may have to adjust the frame size for other peripherals.
In the case of the OMAP1
22 matches
Mail list logo
