Re: [PATCH RFC 07/31] mmc: sdhci: push card_tasklet into threaded irq handler

2014-02-22 Thread Chris Ball
Hi, On Fri, Feb 21 2014, Russell King - ARM Linux wrote: On Thu, Feb 20, 2014 at 04:48:58PM +0530, Viresh Kumar wrote: Nothing wrong in that, only right.. Do you want me to float a patch for this or you can get that done along with your series? I'll send a follow-up mini-series of five

Re: [PATCH RFC 07/31] mmc: sdhci: push card_tasklet into threaded irq handler

2014-02-22 Thread Russell King - ARM Linux
On Sat, Feb 22, 2014 at 06:27:06PM +, Chris Ball wrote: Hi, On Fri, Feb 21 2014, Russell King - ARM Linux wrote: On Thu, Feb 20, 2014 at 04:48:58PM +0530, Viresh Kumar wrote: Nothing wrong in that, only right.. Do you want me to float a patch for this or you can get that done along

Re: [PATCH RFC 07/31] mmc: sdhci: push card_tasklet into threaded irq handler

2014-02-22 Thread Chris Ball
Hi Russell, On Sat, Feb 22 2014, Russell King - ARM Linux wrote: I'll send a follow-up mini-series of five patches for it. It shouldn't depend all that much on the bigger series - and I think the first two patches could well do with going into -rc. Thanks. Since testing resources might

Re: [PATCH RFC 07/31] mmc: sdhci: push card_tasklet into threaded irq handler

2014-02-21 Thread Russell King - ARM Linux
On Thu, Feb 20, 2014 at 04:48:58PM +0530, Viresh Kumar wrote: Nothing wrong in that, only right.. Do you want me to float a patch for this or you can get that done along with your series? I'll send a follow-up mini-series of five patches for it. It shouldn't depend all that much on the bigger

Re: [PATCH RFC 07/31] mmc: sdhci: push card_tasklet into threaded irq handler

2014-02-20 Thread Russell King - ARM Linux
On Wed, Feb 19, 2014 at 04:25:12PM +0530, Viresh Kumar wrote: Absolutely, it will work. Thanks for your efforts in cleaning up this stuff.. I'll send a few patches in a moment. First through, I've just found this gem: static int sdhci_probe(struct platform_device *pdev) { ... sdhci

Re: [PATCH RFC 07/31] mmc: sdhci: push card_tasklet into threaded irq handler

2014-02-20 Thread Viresh Kumar
On 20 February 2014 16:29, Russell King - ARM Linux li...@arm.linux.org.uk wrote: I'll send a few patches in a moment. First through, I've just found this gem: Yeah, 'gem' is the real word for this precious code :) static int sdhci_probe(struct platform_device *pdev) { ... sdhci =

Re: [PATCH RFC 07/31] mmc: sdhci: push card_tasklet into threaded irq handler

2014-02-19 Thread Russell King - ARM Linux
On Wed, Feb 19, 2014 at 11:43:19AM +0530, Viresh Kumar wrote: Adding ST people as well who have access to boards and are working on SPEAr. On 18 February 2014 23:27, Russell King - ARM Linux li...@arm.linux.org.uk wrote: 1) You're controlling the card power GPIO via the insertion/removal

Re: [PATCH RFC 07/31] mmc: sdhci: push card_tasklet into threaded irq handler

2014-02-19 Thread Viresh Kumar
On 19 February 2014 15:13, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Wed, Feb 19, 2014 at 11:43:19AM +0530, Viresh Kumar wrote: Adding ST people as well who have access to boards and are working on SPEAr. On 18 February 2014 23:27, Russell King - ARM Linux

Re: [PATCH RFC 07/31] mmc: sdhci: push card_tasklet into threaded irq handler

2014-02-19 Thread Viresh Kumar
On 19 February 2014 15:22, Russell King - ARM Linux li...@arm.linux.org.uk wrote: Are you aware that power control to the card is part of the MMC/SD/SDIO spec - and part of the protocol talking to the card? Hence why the mmc layer has support for its control built-in. Yeah, almost everything

Re: [PATCH RFC 07/31] mmc: sdhci: push card_tasklet into threaded irq handler

2014-02-19 Thread Russell King - ARM Linux
On Wed, Feb 19, 2014 at 03:39:35PM +0530, Viresh Kumar wrote: On 19 February 2014 15:22, Russell King - ARM Linux li...@arm.linux.org.uk wrote: If you don't want to use a regulator, then the right way to do this is to use the set_ios callback and check the power field - anything which is not

Re: [PATCH RFC 07/31] mmc: sdhci: push card_tasklet into threaded irq handler

2014-02-19 Thread Viresh Kumar
Thanks for removing my ST email id from this mail, I was about to do that this time :) On 19 February 2014 16:20, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Wed, Feb 19, 2014 at 03:39:35PM +0530, Viresh Kumar wrote: I didn't get that completely here.. sorry completely out of

Re: [PATCH RFC 07/31] mmc: sdhci: push card_tasklet into threaded irq handler

2014-02-18 Thread Russell King - ARM Linux
On Tue, Feb 18, 2014 at 03:09:38PM +, Russell King wrote: There's no requirement to have the card tasklet separate now that we have a threaded interrupt handler, so kill this and move the called code into the threaded part of the handler. This patch breaks sdhci-spear's build due to this:

Re: [PATCH RFC 07/31] mmc: sdhci: push card_tasklet into threaded irq handler

2014-02-18 Thread Viresh Kumar
Adding ST people as well who have access to boards and are working on SPEAr. On 18 February 2014 23:27, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Tue, Feb 18, 2014 at 03:09:38PM +, Russell King wrote: There's no requirement to have the card tasklet separate now that we have