Re: [PATCH V2] mmc: Enable the ADMA on esdhc imx driver

2011-06-17 Thread Wolfram Sang
Hi Richard, >It's strange that the sd card can't work on MX25 board without ADMA_BROKEN >quirks. BTW how many cards/boards have you tested? Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | ht

Re: [PATCH V2] mmc: Enable the ADMA on esdhc imx driver

2011-06-16 Thread Wolfram Sang
On Thu, Jun 16, 2011 at 02:06:29PM +0200, Pavel Machek wrote: > On Thu 2011-06-16 14:00:09, Wolfram Sang wrote: > > > > > Unfortunately register differences are common. Is there better > > > approach than patching it in low level functions like this? > > > > I am all ears for suggestions... > >

Re: [PATCH V2] mmc: Enable the ADMA on esdhc imx driver

2011-06-16 Thread Pavel Machek
On Thu 2011-06-16 14:00:09, Wolfram Sang wrote: > > > Unfortunately register differences are common. Is there better > > approach than patching it in low level functions like this? > > I am all ears for suggestions... One way would be to move functions such as sdhci_activate_led() to the low

Re: [PATCH V2] mmc: Enable the ADMA on esdhc imx driver

2011-06-16 Thread Wolfram Sang
> Unfortunately register differences are common. Is there better > approach than patching it in low level functions like this? I am all ears for suggestions... -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.p

Re: [PATCH V2] mmc: Enable the ADMA on esdhc imx driver

2011-06-16 Thread Pavel Machek
Hi! > Eanble the ADMA2 mode on freescale esdhc imx driver, > tested on MX51 and MX53. > > Only ADMA2 mode is enabled, MX25/35 can't support the ADMA2 mode. > So this patch is only used for MX51/53. > The ADMA2 mode supported or not can be distinguished by the > Capability Register(offset 0x40) of

[PATCH V2] mmc: Enable the ADMA on esdhc imx driver

2011-06-08 Thread Richard Zhu
Eanble the ADMA2 mode on freescale esdhc imx driver, tested on MX51 and MX53. Only ADMA2 mode is enabled, MX25/35 can't support the ADMA2 mode. So this patch is only used for MX51/53. The ADMA2 mode supported or not can be distinguished by the Capability Register(offset 0x40) of eSDHC module. Up t