Re: [PATCH V3 4/4] mmc: sdhci-esdhc: enable esdhc on imx53

2011-03-03 Thread Wolfram Sang
+/* Abort type definition in the command register */ +#define SDHCI_CMD_ABORTCMD0xC0 Won't that belong into sd.h (unless I misunderstood your last mail)? This is the bit definitions of the ABORTCMD CMD-TYPE on the bit6~7 of CMD register. Here is the definition

Re: [PATCH V3 4/4] mmc: sdhci-esdhc: enable esdhc on imx53

2011-03-01 Thread Wolfram Sang
Hi Richard, Thanks a lot for your review-comments firstly. :) You are welcome :) +/* Abort type definition in the command register */ +#define SDHCI_CMD_ABORTCMD0xC0 Won't that belong into sd.h (unless I misunderstood your last mail)? This is the bit definitions of the

RE: [PATCH V3 4/4] mmc: sdhci-esdhc: enable esdhc on imx53

2011-03-01 Thread Zhu Richard-R65037
; avoront...@ru.mvista.com; e...@eukrea.com; linux...@gmail.com; Zhao Richard-B20223; freesc...@lists.linaro.org; eric.m...@linaro.org Subject: Re: [PATCH V3 4/4] mmc: sdhci-esdhc: enable esdhc on imx53 Hi Richard, Thanks a lot for your review-comments firstly. :) You are welcome

[PATCH V3 4/4] mmc: sdhci-esdhc: enable esdhc on imx53

2011-02-28 Thread Richard Zhu
Fix the NO INT in the Multi-BLK IO in SD/MMC, and Multi-BLK read in SDIO The CMDTYPE of the CMD register(offset 0xE) should be set to 11 when the STOP CMD12 is issued on imx53 to abort one open ended multi-blk IO. Otherwise one the TC INT wouldn't be generated. In exact block transfer, the

[PATCH V3 4/4] mmc: sdhci-esdhc: enable esdhc on imx53

2011-02-28 Thread Richard Zhu
Fix the NO INT in the Multi-BLK IO in SD/MMC, and Multi-BLK read in SDIO The CMDTYPE of the CMD register(offset 0xE) should be set to 11 when the STOP CMD12 is issued on imx53 to abort one open ended multi-blk IO. Otherwise one the TC INT wouldn't be generated. In exact block transfer, the

Re: [PATCH V3 4/4] mmc: sdhci-esdhc: enable esdhc on imx53

2011-02-28 Thread Wolfram Sang
On Mon, Feb 28, 2011 at 07:32:05PM +0800, Richard Zhu wrote: Fix the NO INT in the Multi-BLK IO in SD/MMC, and Multi-BLK read in SDIO The CMDTYPE of the CMD register(offset 0xE) should be set to 11 when the STOP CMD12 is issued on imx53 to abort one open ended multi-blk IO. Otherwise one

RE: [PATCH V3 4/4] mmc: sdhci-esdhc: enable esdhc on imx53

2011-02-28 Thread Zhu Richard-R65037
...@pengutronix.de; linux- m...@vger.kernel.org; c...@laptop.org; avoront...@ru.mvista.com; e...@eukrea.com; linux...@gmail.com; Zhao Richard-B20223; freesc...@lists.linaro.org; eric.m...@linaro.org Subject: Re: [PATCH V3 4/4] mmc: sdhci-esdhc: enable esdhc on imx53 On Mon, Feb 28, 2011 at 07:32:05PM +0800

Re: [PATCH V3 4/4] mmc: sdhci-esdhc: enable esdhc on imx53

2011-02-28 Thread Eric Miao
Hmm, to me, just using cpu_is_mx53() is more readable than introducing another layer of flags/quirks. Hi Wolfram: I discussed it with Richard Zhao before sending out these V3 patches. As we know that there is not only mx53 has this issue, maybe some following SOCs have this issue too. So