RE: [PATCH v1 3/3]mmc: changes to enable runtime PM of mmc core layer

2010-11-30 Thread Gao, Yunpeng
>You shouldn't do this here. > >You didn't comment about or mentioned this change, but I guess you did >it because you (quite reasonably) didn't want the card to be powered >off as soon as mmc_blk_issue_rq() completes, and instead, you >preferred to wait until some period of inactivity time passes.

Re: [PATCH v1 3/3]mmc: changes to enable runtime PM of mmc core layer

2010-11-30 Thread Ohad Ben-Cohen
Hi Yunpeng, On Sat, Nov 27, 2010 at 9:53 PM, Yunpeng Gao wrote: >  static int mmc_runtime_idle(struct device *dev) >  { > -       return pm_runtime_suspend(dev); > +       return pm_schedule_suspend(dev, 100); You shouldn't do this here. You didn't comment about or mentioned this change, but I

[PATCH v1 3/3]mmc: changes to enable runtime PM of mmc core layer

2010-11-27 Thread Yunpeng Gao
>From cac07f43de68615cca9f01f619870fdce05df2a2 Mon Sep 17 00:00:00 2001 From: Yunpeng Gao Date: Sun, 28 Nov 2010 13:00:42 +0800 Subject: [PATCH] Do some changes in mmc core layer to enable mmc card runtime pm. Seems current runtime PM support in mmc core layer has some problems: 1. If host con