Hi,
On 05/08/2014 05:35 PM, Maxime Ripard wrote:
> On Thu, May 08, 2014 at 02:30:55PM +0200, Hans de Goede wrote:
>> Hi,
>>
>> On 05/08/2014 02:17 PM, Ulf Hansson wrote:
>>> On 8 May 2014 13:26, Hans de Goede wrote:
Hi,
On 05/05/2014 10:33 PM, Ulf Hansson wrote:
> [snip]
>
On Thu, May 08, 2014 at 02:30:55PM +0200, Hans de Goede wrote:
> Hi,
>
> On 05/08/2014 02:17 PM, Ulf Hansson wrote:
> > On 8 May 2014 13:26, Hans de Goede wrote:
> >> Hi,
> >>
> >> On 05/05/2014 10:33 PM, Ulf Hansson wrote:
> >>> [snip]
> >>>
> On 05/05/2014 02:41 PM, Ulf Hansson wrote:
> >>
Hi,
On 05/08/2014 02:17 PM, Ulf Hansson wrote:
> On 8 May 2014 13:26, Hans de Goede wrote:
>> Hi,
>>
>> On 05/05/2014 10:33 PM, Ulf Hansson wrote:
>>> [snip]
>>>
On 05/05/2014 02:41 PM, Ulf Hansson wrote:
>> +struct sunxi_mmc_host {
>> + struct mmc_host *mmc;
>> + str
On 8 May 2014 13:26, Hans de Goede wrote:
> Hi,
>
> On 05/05/2014 10:33 PM, Ulf Hansson wrote:
>> [snip]
>>
>>> On 05/05/2014 02:41 PM, Ulf Hansson wrote:
> +struct sunxi_mmc_host {
> + struct mmc_host *mmc;
> + struct regulator *vmmc;
Instead of having a specific
Hi,
On 05/05/2014 10:33 PM, Ulf Hansson wrote:
> [snip]
>
>> On 05/05/2014 02:41 PM, Ulf Hansson wrote:
+struct sunxi_mmc_host {
+ struct mmc_host *mmc;
+ struct regulator *vmmc;
>>>
>>> Instead of having a specific regulator for this driver, please use the
>>> mmc_regu
[snip]
> On 05/05/2014 02:41 PM, Ulf Hansson wrote:
>>> +struct sunxi_mmc_host {
>>> + struct mmc_host *mmc;
>>> + struct regulator *vmmc;
>>
>> Instead of having a specific regulator for this driver, please use the
>> mmc_regulator_get_supply API.
>
> We cannot use mmc_regulator_get_s
Hi,
Thanks for the review, I will fix most of the issues you've
pointed out, but I've what I believe are good reasons for doing
things as they are done in some other places. For details see below.
Even if you agree with everything I've written below please send
me a reply along those lines, as I
On 2 May 2014 17:57, Hans de Goede wrote:
> From: David Lanzendörfer
>
> The Allwinner sunxi mmc host uses dma in bus-master mode using a built-in
> designware idmac controller, which is identical to the one found in the mmc-dw
> hosts. However the rest of the host is not identical to mmc-dw, it
From: David Lanzendörfer
The Allwinner sunxi mmc host uses dma in bus-master mode using a built-in
designware idmac controller, which is identical to the one found in the mmc-dw
hosts. However the rest of the host is not identical to mmc-dw, it deals with
sending stop commands in hardware which m
