Re: [PATCH v2] dmaengine: shdma: fix a build failure on platforms with no DMA support

2013-06-27 Thread Simon Horman
On Fri, May 31, 2013 at 04:51:52PM +0200, Arnd Bergmann wrote: > On Friday 31 May 2013 05:01:31 Guennadi Liakhovetski wrote: > > On platforms with no support for the shdma dmaengine driver build is > > currently failing with > > > > drivers/built-in.o: In function `sh_mobile_sdhi_probe': > > drive

Re: [PATCH v2] dmaengine: shdma: fix a build failure on platforms with no DMA support

2013-05-31 Thread Arnd Bergmann
On Friday 31 May 2013 10:00:29 Dan Murphy wrote: > My consideration was that since this is an exported symbol that a driver > could call this API explicitly without checking for > the function pointer first, there is a potential of calling a NULL pointer. Drivers never call a filter function direc

Re: [PATCH v2] dmaengine: shdma: fix a build failure on platforms with no DMA support

2013-05-31 Thread Dan Murphy
On 05/31/2013 08:08 AM, Guennadi Liakhovetski wrote: > On Fri, 31 May 2013, Dan Murphy wrote: > >> On 05/30/2013 10:01 PM, Guennadi Liakhovetski wrote: >>> On platforms with no support for the shdma dmaengine driver build is >>> currently failing with >>> >>> drivers/built-in.o: In function `sh_mob

Re: [PATCH v2] dmaengine: shdma: fix a build failure on platforms with no DMA support

2013-05-31 Thread Arnd Bergmann
On Friday 31 May 2013 05:01:31 Guennadi Liakhovetski wrote: > On platforms with no support for the shdma dmaengine driver build is > currently failing with > > drivers/built-in.o: In function `sh_mobile_sdhi_probe': > drivers/mmc/host/sh_mobile_sdhi.c:170: undefined reference > to`shdma_chan_filt

Re: [PATCH v2] dmaengine: shdma: fix a build failure on platforms with no DMA support

2013-05-31 Thread Guennadi Liakhovetski
On Fri, 31 May 2013, Dan Murphy wrote: > On 05/30/2013 10:01 PM, Guennadi Liakhovetski wrote: > > On platforms with no support for the shdma dmaengine driver build is > > currently failing with > > > > drivers/built-in.o: In function `sh_mobile_sdhi_probe': > > drivers/mmc/host/sh_mobile_sdhi.c:17

Re: [PATCH v2] dmaengine: shdma: fix a build failure on platforms with no DMA support

2013-05-31 Thread Dan Murphy
On 05/30/2013 10:01 PM, Guennadi Liakhovetski wrote: > On platforms with no support for the shdma dmaengine driver build is > currently failing with > > drivers/built-in.o: In function `sh_mobile_sdhi_probe': > drivers/mmc/host/sh_mobile_sdhi.c:170: undefined reference > to`shdma_chan_filter' > >

[PATCH v2] dmaengine: shdma: fix a build failure on platforms with no DMA support

2013-05-30 Thread Guennadi Liakhovetski
On platforms with no support for the shdma dmaengine driver build is currently failing with drivers/built-in.o: In function `sh_mobile_sdhi_probe': drivers/mmc/host/sh_mobile_sdhi.c:170: undefined reference to`shdma_chan_filter' Fix the breakage by defining shdma_chan_filter to NULL in such confi