Re: [PATCH v2] mmc: sdhci: fix incorrect command used in tuning

2012-11-08 Thread Chris Ball
Hi Aaron, On Mon, Nov 05 2012, Chris Ball wrote: On Tue, Jul 03 2012, Aaron Lu wrote: */ if ((host-flags SDHCI_NEEDS_RETUNING) !(present_state (SDHCI_DOING_WRITE | SDHCI_DOING_READ))) { +/* eMMC uses cmd21 while sd and sdio

Re: [PATCH v2] mmc: sdhci: fix incorrect command used in tuning

2012-11-05 Thread Chris Ball
Hi Aaron, On Tue, Jul 03 2012, Aaron Lu wrote: */ if ((host-flags SDHCI_NEEDS_RETUNING) !(present_state (SDHCI_DOING_WRITE | SDHCI_DOING_READ))) { + /* eMMC uses cmd21 while sd and sdio use cmd19 */ +

[PATCH v2] mmc: sdhci: fix incorrect command used in tuning

2012-07-03 Thread Aaron Lu
V2: Fix for SDIO case: both SD and SDIO cards use cmd19 while eMMC use cmd21. V1: For SD hosts using retuning mode 1, when retuning timer expired, it will need to do retuning in sdhci_request before processing the actual request. But the retuning command is fixed: cmd19 for SD card and cmd21 for

Re: [PATCH v2] mmc: sdhci: fix incorrect command used in tuning

2012-07-03 Thread Girish K S
On 3 July 2012 14:57, Aaron Lu aaron...@amd.com wrote: V2: Fix for SDIO case: both SD and SDIO cards use cmd19 while eMMC use cmd21. V1: For SD hosts using retuning mode 1, when retuning timer expired, it will need to do retuning in sdhci_request before processing the actual request. But

Re: [PATCH v2] mmc: sdhci: fix incorrect command used in tuning

2012-07-03 Thread Aaron Lu
Hi, On Tue, Jul 03, 2012 at 03:28:28PM +0530, Girish K S wrote: On 3 July 2012 14:57, Aaron Lu aaron...@amd.com wrote: V2: Fix for SDIO case: both SD and SDIO cards use cmd19 while eMMC use cmd21. V1: For SD hosts using retuning mode 1, when retuning timer expired, it will need to do

Re: [PATCH v2] mmc: sdhci: fix incorrect command used in tuning

2012-07-03 Thread Girish K S
On 3 July 2012 17:01, Aaron Lu aaron...@amd.com wrote: Hi, On Tue, Jul 03, 2012 at 03:28:28PM +0530, Girish K S wrote: On 3 July 2012 14:57, Aaron Lu aaron...@amd.com wrote: V2: Fix for SDIO case: both SD and SDIO cards use cmd19 while eMMC use cmd21. V1: For SD hosts using retuning

Re: [PATCH v2] mmc: sdhci: fix incorrect command used in tuning

2012-07-03 Thread Girish K S
On 3 July 2012 17:27, Girish K S girish.shivananja...@linaro.org wrote: On 3 July 2012 17:01, Aaron Lu aaron...@amd.com wrote: Hi, On Tue, Jul 03, 2012 at 03:28:28PM +0530, Girish K S wrote: On 3 July 2012 14:57, Aaron Lu aaron...@amd.com wrote: V2: Fix for SDIO case: both SD and SDIO

Re: [PATCH v2] mmc: sdhci: fix incorrect command used in tuning

2012-07-03 Thread Girish K S
On 3 July 2012 17:27, Girish K S girish.shivananja...@linaro.org wrote: On 3 July 2012 17:01, Aaron Lu aaron...@amd.com wrote: Hi, On Tue, Jul 03, 2012 at 03:28:28PM +0530, Girish K S wrote: On 3 July 2012 14:57, Aaron Lu aaron...@amd.com wrote: V2: Fix for SDIO case: both SD and SDIO

Re: [PATCH v2] mmc: sdhci: fix incorrect command used in tuning

2012-07-03 Thread Aaron Lu
Hi, On Tue, Jul 03, 2012 at 05:32:36PM +0530, Girish K S wrote: @@ -1292,8 +1294,12 @@ static void sdhci_request(struct mmc_host *mmc, struct mmc_request *mrq)                  */                 if ((host-flags SDHCI_NEEDS_RETUNING)                     !(present_state

RE: [PATCH v2] mmc: sdhci: fix incorrect command used in tuning

2012-07-03 Thread Philip Rakity
+]@domain.invalid Subject: [PATCH v2] mmc: sdhci: fix incorrect command used in tuning V2: Fix for SDIO case: both SD and SDIO cards use cmd19 while eMMC use cmd21. V1: For SD hosts using retuning mode 1, when retuning timer expired, it will need to do retuning in sdhci_request before processing the actual

Re: [PATCH v2] mmc: sdhci: fix incorrect command used in tuning

2012-07-03 Thread Chris Ball
Hi, On Tue, Jul 03 2012, Aaron Lu wrote: V2: Fix for SDIO case: both SD and SDIO cards use cmd19 while eMMC use cmd21. V1: For SD hosts using retuning mode 1, when retuning timer expired, it will need to do retuning in sdhci_request before processing the actual request. But the retuning

Re: [PATCH v2] mmc: sdhci: fix incorrect command used in tuning

2012-07-03 Thread Aaron Lu
Hi Chris, On Tue, Jul 03, 2012 at 08:37:33PM -0400, Chris Ball wrote: Hi, On Tue, Jul 03 2012, Aaron Lu wrote: V2: Fix for SDIO case: both SD and SDIO cards use cmd19 while eMMC use cmd21. V1: For SD hosts using retuning mode 1, when retuning timer expired, it will need to do