Re: [PATCH v2] mmc: slot-gpio: Add support for power gpios

2012-09-10 Thread Guennadi Liakhovetski
Hi Chris On Sun, 9 Sep 2012, Chris Ball wrote: > A power gpio is a sideband output gpio that controls card power. Thanks for the patch. It looks good formally now, thanks for taking into account my comments. However, I'm wondering: this GPIO is different from the previous two - it's an output.

[PATCH v2] mmc: slot-gpio: Add support for power gpios

2012-09-09 Thread Chris Ball
A power gpio is a sideband output gpio that controls card power. Signed-off-by: Chris Ball --- Changelog: v2, addressing Guennadi's review comments: - More consistent comment and operator coding style - Only store pwr_gpio in ctx if requesting it was successful - Use GPIOF_OUT_INIT_{LOW,HIGH}