Re: [PATCH v2] sdio: skip initialization on powered resume

On Tue, Jan 25, 2011 at 9:11 AM, Ohad Ben-Cohen wrote: > One thing we can do is letting drivers register a wake-up function > within the SDIO core, just before suspending. Then, upon resume, if > such a wake-up function was registered, SDIO core would invoke it just > before it tries to read the C

Re: [PATCH v2] sdio: skip initialization on powered resume

Hello Zhangfei, On Tue, Jan 25, 2011 at 5:10 AM, zhangfei gao wrote: > Could we remove mmc_card_is_removable(host) condition, the skip is not > related with whether card is removable or not, do you think so? But, as Nicolas pointed out before, what if the card is removed (or replaced) while the

Re: [PATCH v2] sdio: skip initialization on powered resume

inux-mmc@vger.kernel.org; >> Michal Miroslaw; Chris Ball; >> Andrew Morton; Maxim Levitsky >> Subject: Re: [PATCH v2] sdio: skip initialization on powered resume >> >> On Fri, Jan 21, 2011 at 11:07 AM, zhangfei gao >> wrote: >> > Do you have any updated p

RE: [PATCH v2] sdio: skip initialization on powered resume

im Levitsky > Subject: Re: [PATCH v2] sdio: skip initialization on powered resume > > On Fri, Jan 21, 2011 at 11:07 AM, zhangfei gao wrote: > > Do you have any updated patch to skip mmc_sdio_init_card in resume back. > > We need such patch in enable host sleep feature for m

Re: [PATCH v2] sdio: skip initialization on powered resume

On Fri, Jan 21, 2011 at 11:07 AM, zhangfei gao wrote: > Do you have any updated patch to skip mmc_sdio_init_card in resume back. > We need such patch in enable host sleep feature for mrvl8787. Is mrvl8787 a removable card ? I'm asking because we already skip mmc_sdio_init_card() for powered-resu

Re: [PATCH v2] sdio: skip initialization on powered resume

Hi Bing, On Fri, Jan 21, 2011 at 07:27:06PM -0800, Bing Zhao wrote: > I'll rebase and test the patch based on > git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc.git tree. Should I use > "master" or "mmc-next" branch? mmc-next, please. Thanks! -- Chris Ball One

RE: [PATCH v2] sdio: skip initialization on powered resume

011 1:07 AM > > > To: Nicolas Pitre; Bing Zhao > > > Cc: Sahitya Tummala; linux-mmc@vger.kernel.org; Michal Miroslaw; Chris > > > Ball; Andrew Morton; Maxim > > > Levitsky > > > Subject: Re: [PATCH v2] sdio: skip initialization on powered re

RE: [PATCH v2] sdio: skip initialization on powered resume

r.kernel.org; Michal Miroslaw; Chris > > Ball; Andrew Morton; Maxim > > Levitsky > > Subject: Re: [PATCH v2] sdio: skip initialization on powered resume > > > > On Wed, Sep 15, 2010 at 10:26 PM, Nicolas Pitre wrote: > > > On Wed, 15 Sep 2010, Bing Zhao wrote: >

RE: [PATCH v2] sdio: skip initialization on powered resume

evitsky > Subject: Re: [PATCH v2] sdio: skip initialization on powered resume > > On Wed, Sep 15, 2010 at 10:26 PM, Nicolas Pitre wrote: > > On Wed, 15 Sep 2010, Bing Zhao wrote: > > > >> If CMD7 is sent _before_ client driver's resume handler is called, > &g

Re: [PATCH v2] sdio: skip initialization on powered resume

On Wed, Sep 15, 2010 at 10:26 PM, Nicolas Pitre wrote: > On Wed, 15 Sep 2010, Bing Zhao wrote: > >> If CMD7 is sent _before_ client driver's resume handler is called, >> while 8686 card is in sleep mode, it will fail. If CMD7 is sent >> _after_ client driver's resume handler is called, it should s

RE: [PATCH v2] sdio: skip initialization on powered resume

On Wed, 15 Sep 2010, Bing Zhao wrote: > If CMD7 is sent _before_ client driver's resume handler is called, > while 8686 card is in sleep mode, it will fail. If CMD7 is sent > _after_ client driver's resume handler is called, it should succeed. Maybe that's what we should do in the powered suspe

RE: [PATCH v2] sdio: skip initialization on powered resume

sday, September 07, 2010 6:29 PM > > > To: Bing Zhao > > > Cc: linux-mmc@vger.kernel.org; Michal Miroslaw; Chris Ball; Andrew Morton > > > Subject: RE: [PATCH v2] sdio: skip initialization on powered resume > > > > > > On Tue, 7 Sep 2010, Bing Zhao wrot

RE: [PATCH v2] sdio: skip initialization on powered resume

nel.org; Michal Miroslaw; Chris Ball; Andrew Morton > > Subject: RE: [PATCH v2] sdio: skip initialization on powered resume > > > > On Tue, 7 Sep 2010, Bing Zhao wrote: > > > > > Thanks for the hint. > > > > > > The new patch skips reading CCCR,

RE: [PATCH v2] sdio: skip initialization on powered resume

Hi Nicolas, > -Original Message- > From: Nicolas Pitre [mailto:n...@fluxnic.net] > Sent: Tuesday, September 07, 2010 6:29 PM > To: Bing Zhao > Cc: linux-mmc@vger.kernel.org; Michal Miroslaw; Chris Ball; Andrew Morton > Subject: RE: [PATCH v2] sdio: skip initialization

RE: [PATCH v2] sdio: skip initialization on powered resume

On Tue, 7 Sep 2010, Bing Zhao wrote: > Thanks for the hint. > > The new patch skips reading CCCR, common CIS, and validation of > vendor/device IDs inside mmc_sdio_init_card() when powered_resume is > not zero. Why do you skip the reading of the CIS and IDs validation? That's basically the m

RE: [PATCH v2] sdio: skip initialization on powered resume

Hi Nicolas, > -Original Message- > From: Nicolas Pitre [mailto:n...@fluxnic.net] > Sent: Thursday, September 02, 2010 4:30 PM > To: Bing Zhao > Cc: linux-mmc@vger.kernel.org; Michal Miroslaw; Chris Ball; Andrew Morton > Subject: RE: [PATCH v2] sdio: skip initialization

RE: [PATCH v2] sdio: skip initialization on powered resume

On Thu, 2 Sep 2010, Bing Zhao wrote: > > Please look at the if() condition, and at the last argument to > > mmc_sdio_init_card(), then ponder. > > You are right. The last argument passed to mmc_sdio_init_card() is zero > actually. > > err = mmc_sdio_init_card(host, host->ocr, host

RE: [PATCH v2] sdio: skip initialization on powered resume

Hi Nicolas, Thanks for your comments. > -Original Message- > From: Nicolas Pitre [mailto:n...@fluxnic.net] > Sent: Thursday, September 02, 2010 10:54 AM > To: Bing Zhao > Cc: linux-mmc@vger.kernel.org; Michal Miroslaw; Chris Ball; Andrew Morton > Subject: Re: [PA

Re: [PATCH v2] sdio: skip initialization on powered resume

On Wed, 1 Sep 2010, Bing Zhao wrote: > Quoted Michal Miroslaw's comment: > > Simplified SDIO spec v.2.00 (section 6.14 - Bus State Diagram) > suggests, that initialization commands (CMD5, CMD3) are not accepted > in CMD state. As the card stays in that state on powered suspend (no > resetting CMD

[PATCH v2] sdio: skip initialization on powered resume

Quoted Michal Miroslaw's comment: Simplified SDIO spec v.2.00 (section 6.14 - Bus State Diagram) suggests, that initialization commands (CMD5, CMD3) are not accepted in CMD state. As the card stays in that state on powered suspend (no resetting CMD52 nor power cycle is issued) then reinitializatio