Re: [PATCH v2 0/6] ARM: sunxi: Add driver for SD/MMC hosts found on allwinner sunxi SOCs

2014-02-05 Thread Maxime Ripard
Hi David, On Tue, Feb 04, 2014 at 08:24:13PM +0100, David Lanzendörfer wrote: Hello The following patchset adds support for the SD/MMC host found in the Allwinner SoCs. It contains all the necessary modifications for clock environment and also the device tree script modification which add

Re: [PATCH v2 0/6] ARM: sunxi: Add driver for SD/MMC hosts found on allwinner sunxi SOCs

2014-02-05 Thread David Lanzendörfer
Hi Maxime I have four comments here: - Read Documentation/SubmittingPatches, especially Section 5 and 12 (hints, you forgot the clock maintainers for your clock patches and you didn't put any signed-off-by tags) Oops. I added signed-offs now - You ignored pretty much all the

Re: [PATCH v2 0/6] ARM: sunxi: Add driver for SD/MMC hosts found on allwinner sunxi SOCs

2014-02-05 Thread Hans de Goede
Hi David, On 02/05/2014 02:01 PM, David Lanzendörfer wrote: Hi Maxime I have four comments here: - Read Documentation/SubmittingPatches, especially Section 5 and 12 (hints, you forgot the clock maintainers for your clock patches and you didn't put any signed-off-by tags) Oops. I

[PATCH v2 0/6] ARM: sunxi: Add driver for SD/MMC hosts found on allwinner sunxi SOCs

2014-02-04 Thread David Lanzendörfer
Hello The following patchset adds support for the SD/MMC host found in the Allwinner SoCs. It contains all the necessary modifications for clock environment and also the device tree script modification which add it to all the boards using it. The clock environment function needed for phase

Re: [PATCH v2 0/6] ARM: sunxi: Add driver for SD/MMC hosts found on allwinner sunxi SOCs

2014-02-04 Thread David Lanzendörfer
Hi I forgot to mention that the autoparenting patch of Emilios is a crucial depency... http://git.o2s.ch/?p=linux-next.git;a=commit;h=f8e936772672a3a6ec934558d2a7aef030c663c4 Without it, the clock will return the wrong value and the card will refuse to initialize regards david signature.asc