Re: [PATCH v2 02/11] mmc: deprecate redundant cd-inverted and wp-inverted DT properties

2013-01-31 Thread Arnd Bergmann
On Thursday 31 January 2013, Guennadi Liakhovetski wrote: > On Thu, 31 Jan 2013, Arnd Bergmann wrote: > > On Wednesday 30 January 2013, Guennadi Liakhovetski wrote: > > > On Wed, 30 Jan 2013, Arnd Bergmann wrote: > > > > I'm not saying that it should, I just thought that it did that already, > > b

Re: [PATCH v2 02/11] mmc: deprecate redundant cd-inverted and wp-inverted DT properties

2013-01-30 Thread Guennadi Liakhovetski
On Thu, 31 Jan 2013, Arnd Bergmann wrote: > On Wednesday 30 January 2013, Guennadi Liakhovetski wrote: > > On Wed, 30 Jan 2013, Arnd Bergmann wrote: > > > > > On Wednesday 30 January 2013, Guennadi Liakhovetski wrote: > > > > > This means, that a multi-platform driver like, e.g. SDHCI cannot use

Re: [PATCH v2 02/11] mmc: deprecate redundant cd-inverted and wp-inverted DT properties

2013-01-30 Thread Chris Ball
Hi, On Wed, Jan 30 2013, Arnd Bergmann wrote: >> > From the code, I understand that of_get_named_gpio() would return a gpio >> > line with the polarity already inverted if it's specified that way, >> >> Sorry, don't understand. of_get_named_gpio() just returns a GPIO number, >> not GPIO level. I

Re: [PATCH v2 02/11] mmc: deprecate redundant cd-inverted and wp-inverted DT properties

2013-01-30 Thread Arnd Bergmann
On Wednesday 30 January 2013, Guennadi Liakhovetski wrote: > On Wed, 30 Jan 2013, Arnd Bergmann wrote: > > > On Wednesday 30 January 2013, Guennadi Liakhovetski wrote: > > > > This means, that a multi-platform driver like, e.g. SDHCI cannot use > > > > the > > > > gpio "flags" cell and has to fa

Re: [PATCH v2 02/11] mmc: deprecate redundant cd-inverted and wp-inverted DT properties

2013-01-30 Thread Guennadi Liakhovetski
On Wed, 30 Jan 2013, Arnd Bergmann wrote: > On Wednesday 30 January 2013, Guennadi Liakhovetski wrote: > > > This means, that a multi-platform driver like, e.g. SDHCI cannot use the > > > gpio "flags" cell and has to fall-back to always use "*-inverted" > > > properties. Same holds for any other

Re: [PATCH v2 02/11] mmc: deprecate redundant cd-inverted and wp-inverted DT properties

2013-01-30 Thread Arnd Bergmann
On Wednesday 30 January 2013, Guennadi Liakhovetski wrote: > > This means, that a multi-platform driver like, e.g. SDHCI cannot use the > > gpio "flags" cell and has to fall-back to always use "*-inverted" > > properties. Same holds for any other multi-arch driver, using GPIOs. So, > > we're stu

Re: [PATCH v2 02/11] mmc: deprecate redundant cd-inverted and wp-inverted DT properties

2013-01-30 Thread Guennadi Liakhovetski
On Wed, 30 Jan 2013, Guennadi Liakhovetski wrote: > Hi Arnd > > Thanks for your input. > > On Wed, 30 Jan 2013, Arnd Bergmann wrote: > > > On Monday 28 January 2013, Chris Ball wrote: > > > On Wed, Jan 23 2013, Guennadi Liakhovetski wrote: > > > > +cd-inverted and wp-inverted properties are dep

Re: [PATCH v2 02/11] mmc: deprecate redundant cd-inverted and wp-inverted DT properties

2013-01-30 Thread Guennadi Liakhovetski
Hi Arnd Thanks for your input. On Wed, 30 Jan 2013, Arnd Bergmann wrote: > On Monday 28 January 2013, Chris Ball wrote: > > On Wed, Jan 23 2013, Guennadi Liakhovetski wrote: > > > +cd-inverted and wp-inverted properties are deprecated ans shouldn't be > > > used, > > > +instead pleaseuse the OF

Re: [PATCH v2 02/11] mmc: deprecate redundant cd-inverted and wp-inverted DT properties

2013-01-30 Thread Arnd Bergmann
On Monday 28 January 2013, Chris Ball wrote: > On Wed, Jan 23 2013, Guennadi Liakhovetski wrote: > > +cd-inverted and wp-inverted properties are deprecated ans shouldn't be > > used, > > +instead pleaseuse the OF_GPIO_ACTIVE_LOW flag in respective GPIO bindings. > > Note, > > +that the default (a

Re: [PATCH v2 02/11] mmc: deprecate redundant cd-inverted and wp-inverted DT properties

2013-01-28 Thread Chris Ball
Hi Guennadi, On Wed, Jan 23 2013, Guennadi Liakhovetski wrote: > +cd-inverted and wp-inverted properties are deprecated ans shouldn't be used, > +instead pleaseuse the OF_GPIO_ACTIVE_LOW flag in respective GPIO bindings. > Note, > +that the default (as defined by the SDHCI standard) CD and WP pol

[PATCH v2 02/11] mmc: deprecate redundant cd-inverted and wp-inverted DT properties

2013-01-23 Thread Guennadi Liakhovetski
GPIO DT bindings have a standard way to specify GPIO polarity - the OF_GPIO_ACTIVE_LOW flag. Use that instead of custom cd-inverted and wp-inverted properties. Signed-off-by: Guennadi Liakhovetski --- Documentation/devicetree/bindings/mmc/mmc.txt |8 1 files changed, 8 insertions(+)