Re: [PATCH v2 03/12] clk: Add a function to retrieve phase

2014-09-02 Thread Maxime Ripard
Hi, On Mon, Sep 01, 2014 at 12:00:54PM -0700, Mike Turquette wrote: Quoting Maxime Ripard (2014-08-30 13:03:02) The current phase API doesn't look into the actual hardware to get the phase value, but will rather get it from a variable only set by the set_phase function. This will

Re: [PATCH v2 03/12] clk: Add a function to retrieve phase

2014-09-02 Thread Maxime Ripard
On Mon, Sep 01, 2014 at 01:27:28PM +0200, Hans de Goede wrote: Hi, On 09/01/2014 12:20 PM, Maxime Ripard wrote: Hi, On Sun, Aug 31, 2014 at 12:15:50PM +0200, Hans de Goede wrote: Hi, On 08/30/2014 10:03 PM, Maxime Ripard wrote: The current phase API doesn't look into the actual

Re: [PATCH v2 03/12] clk: Add a function to retrieve phase

2014-09-02 Thread David Lanzendörfer
Hi Yep, except that if I see a value -1 as a phase, I would assume that it's 359, but maybe it's just me :) -1 looks suspiciously like an error return value from somewhere... -- David Lanzendörfer OpenSourceSupport GmbH System engineer and supporter http://www.o2s.ch/ signature.asc

Re: [PATCH v2 03/12] clk: Add a function to retrieve phase

2014-09-01 Thread Maxime Ripard
Hi, On Sun, Aug 31, 2014 at 12:15:50PM +0200, Hans de Goede wrote: Hi, On 08/30/2014 10:03 PM, Maxime Ripard wrote: The current phase API doesn't look into the actual hardware to get the phase value, but will rather get it from a variable only set by the set_phase function. This

Re: [PATCH v2 03/12] clk: Add a function to retrieve phase

2014-09-01 Thread Mike Turquette
Quoting Maxime Ripard (2014-08-30 13:03:02) The current phase API doesn't look into the actual hardware to get the phase value, but will rather get it from a variable only set by the set_phase function. This will cause issue when the client driver will never call the set_phase function,

[PATCH v2 03/12] clk: Add a function to retrieve phase

2014-08-30 Thread Maxime Ripard
The current phase API doesn't look into the actual hardware to get the phase value, but will rather get it from a variable only set by the set_phase function. This will cause issue when the client driver will never call the set_phase function, where we can end up having a reported phase that will