Re: [PATCH v2 06/10] mmc: omap_hsmmc: add support for pbias configuration in dt

2013-06-13 Thread Mark Brown
On Thu, Jun 13, 2013 at 09:29:38AM -0700, Tony Lindgren wrote: > * Linus Walleij [130613 08:35]: > > No. If we go down that road *anything* that is connected to a > > pad becomes part of the pinctrl subsystem, then pinctrl-single > > becomes some kind of hardware abstraction or BIOS, and that > >

Re: [PATCH v2 06/10] mmc: omap_hsmmc: add support for pbias configuration in dt

2013-06-13 Thread Tony Lindgren
* Linus Walleij [130613 08:35]: > On Thu, Jun 13, 2013 at 4:41 PM, Balaji T K wrote: > > > You mean regulator via pinctrl APIs, I think It will just move the code > > from omap_hsmmc to a new regulator file with it own init data for pinctrl. > > No I'm not saying you should use pinctrl as a "ba

Re: [PATCH v2 06/10] mmc: omap_hsmmc: add support for pbias configuration in dt

2013-06-13 Thread Lee Jones
On Thu, 13 Jun 2013, Balaji T K wrote: > On Thursday 13 June 2013 04:17 PM, Lee Jones wrote: > >On Thu, 13 Jun 2013, Linus Walleij wrote: > > > >>On Thu, Jun 6, 2013 at 9:14 PM, Balaji T K wrote: > >> > >>>PBIAS register configuration is based on the regulator voltage > >>>which supplies these pb

Re: [PATCH v2 06/10] mmc: omap_hsmmc: add support for pbias configuration in dt

2013-06-13 Thread Linus Walleij
On Thu, Jun 13, 2013 at 4:41 PM, Balaji T K wrote: >[Me] >>> This seem so intuitively wrong as it can possibly get, clearly this >>> is regulator territory. > > It is not really a regulator, CONTROL_PBIAS_LITE is just a register > in control module which configures pad/pin on SOC. In this case PB

Re: [PATCH v2 06/10] mmc: omap_hsmmc: add support for pbias configuration in dt

2013-06-13 Thread Balaji T K
On Thursday 13 June 2013 04:17 PM, Lee Jones wrote: On Thu, 13 Jun 2013, Linus Walleij wrote: On Thu, Jun 6, 2013 at 9:14 PM, Balaji T K wrote: PBIAS register configuration is based on the regulator voltage which supplies these pbias cells, sd i/o pads. With PBIAS register address and bit de

Re: [PATCH v2 06/10] mmc: omap_hsmmc: add support for pbias configuration in dt

2013-06-13 Thread Balaji T K
On Thursday 13 June 2013 03:32 PM, Laurent Pinchart wrote: On Thursday 13 June 2013 02:53:54 Tony Lindgren wrote: * Linus Walleij [130613 02:42]: On Thu, Jun 6, 2013 at 9:14 PM, Balaji T K wrote: PBIAS register configuration is based on the regulator voltage which supplies these pbias cells,

Re: [PATCH v2 06/10] mmc: omap_hsmmc: add support for pbias configuration in dt

2013-06-13 Thread Laurent Pinchart
Hi, On Thursday 13 June 2013 20:22:42 Balaji T K wrote: > On Thursday 13 June 2013 03:32 PM, Laurent Pinchart wrote: > > On Thursday 13 June 2013 02:53:54 Tony Lindgren wrote: > >> * Linus Walleij [130613 02:42]: > >>> On Thu, Jun 6, 2013 at 9:14 PM, Balaji T K wrote: > PBIAS register confi

Re: [PATCH v2 06/10] mmc: omap_hsmmc: add support for pbias configuration in dt

2013-06-13 Thread Balaji T K
On Thursday 13 June 2013 03:23 PM, Tony Lindgren wrote: * Linus Walleij [130613 02:42]: On Thu, Jun 6, 2013 at 9:14 PM, Balaji T K wrote: PBIAS register configuration is based on the regulator voltage which supplies these pbias cells, sd i/o pads. With PBIAS register address and bit definiti

Re: [PATCH v2 06/10] mmc: omap_hsmmc: add support for pbias configuration in dt

2013-06-13 Thread Linus Walleij
On Thu, Jun 13, 2013 at 11:53 AM, Tony Lindgren wrote: > * Linus Walleij [130613 02:42]: >> On Thu, Jun 6, 2013 at 9:14 PM, Balaji T K wrote: >> > + /* 100ms delay required for PBIAS configuration */ >> > + msleep(100); >> > + if (!vdd && host->pinctrl && host->pbias_off) { >>

Re: [PATCH v2 06/10] mmc: omap_hsmmc: add support for pbias configuration in dt

2013-06-13 Thread Lee Jones
On Thu, 13 Jun 2013, Linus Walleij wrote: > On Thu, Jun 6, 2013 at 9:14 PM, Balaji T K wrote: > > > PBIAS register configuration is based on the regulator voltage > > which supplies these pbias cells, sd i/o pads. > > With PBIAS register address and bit definitions different across > > omap[3,4,

Re: [PATCH v2 06/10] mmc: omap_hsmmc: add support for pbias configuration in dt

2013-06-13 Thread Laurent Pinchart
On Thursday 13 June 2013 02:53:54 Tony Lindgren wrote: > * Linus Walleij [130613 02:42]: > > On Thu, Jun 6, 2013 at 9:14 PM, Balaji T K wrote: > > > PBIAS register configuration is based on the regulator voltage > > > which supplies these pbias cells, sd i/o pads. > > > With PBIAS register addres

Re: [PATCH v2 06/10] mmc: omap_hsmmc: add support for pbias configuration in dt

2013-06-13 Thread Tony Lindgren
* Linus Walleij [130613 02:42]: > On Thu, Jun 6, 2013 at 9:14 PM, Balaji T K wrote: > > > PBIAS register configuration is based on the regulator voltage > > which supplies these pbias cells, sd i/o pads. > > With PBIAS register address and bit definitions different across > > omap[3,4,5], Simpli

Re: [PATCH v2 06/10] mmc: omap_hsmmc: add support for pbias configuration in dt

2013-06-13 Thread Linus Walleij
On Wed, Jun 12, 2013 at 4:37 PM, Tony Lindgren wrote: > Linus W may have some comments on this, although this is not the standard > muxing stuff. It's in the wrong subsystem and needs to be rewritten IMO. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-mm

Re: [PATCH v2 06/10] mmc: omap_hsmmc: add support for pbias configuration in dt

2013-06-13 Thread Linus Walleij
On Thu, Jun 6, 2013 at 9:14 PM, Balaji T K wrote: > PBIAS register configuration is based on the regulator voltage > which supplies these pbias cells, sd i/o pads. > With PBIAS register address and bit definitions different across > omap[3,4,5], Simplify PBIAS configuration under three different

Re: [PATCH v2 06/10] mmc: omap_hsmmc: add support for pbias configuration in dt

2013-06-12 Thread Balaji T K
On Wednesday 12 June 2013 08:07 PM, Tony Lindgren wrote: * Balaji T K [130606 12:20]: PBIAS register configuration is based on the regulator voltage which supplies these pbias cells, sd i/o pads. With PBIAS register address and bit definitions different across omap[3,4,5], Simplify PBIAS config

Re: [PATCH v2 06/10] mmc: omap_hsmmc: add support for pbias configuration in dt

2013-06-12 Thread Tony Lindgren
* Balaji T K [130606 12:20]: > PBIAS register configuration is based on the regulator voltage > which supplies these pbias cells, sd i/o pads. > With PBIAS register address and bit definitions different across > omap[3,4,5], Simplify PBIAS configuration under three different > regulator voltage le

[PATCH v2 06/10] mmc: omap_hsmmc: add support for pbias configuration in dt

2013-06-06 Thread Balaji T K
PBIAS register configuration is based on the regulator voltage which supplies these pbias cells, sd i/o pads. With PBIAS register address and bit definitions different across omap[3,4,5], Simplify PBIAS configuration under three different regulator voltage levels - O V, 1.8 V, 3 V. Corresponding pi