Re: [PATCH v2 1/1] mmc: Support of SDIO irq for dw_mmc

2011-08-29 Thread Chris Ball
Hi, On Mon, Aug 29 2011, James Hogan wrote: > On 29 August 2011 07:36, Shashidhar Hiremath > wrote: >> Hi Chris, >>  The git repo that I have cloned is >> git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc.git and created >> my branch against it.Now when I create a patch and apply the patch >>

Re: [PATCH v2 1/1] mmc: Support of SDIO irq for dw_mmc

2011-08-28 Thread James Hogan
On 29 August 2011 07:36, Shashidhar Hiremath wrote: > Hi Chris, >  The git repo that I have cloned is > git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc.git and created > my branch against it.Now when I create a patch and apply the patch > directly.It works fine .If I mail the patch and do a

Re: [PATCH v2 1/1] mmc: Support of SDIO irq for dw_mmc

2011-08-28 Thread Shashidhar Hiremath
Hi Chris, The git repo that I have cloned is git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc.git and created my branch against it.Now when I create a patch and apply the patch directly.It works fine .If I mail the patch and do a copy-paste to a text file and try to apply ,I get some errors

Re: [PATCH v2 1/1] mmc: Support of SDIO irq for dw_mmc

2011-08-28 Thread Chris Ball
Hi Shashidhar, On Tue, Aug 23 2011, Shashidhar Hiremath wrote: > The Patch adds the support for SDIO interrupts for all slots. > It includes enabling of SDIO interrupts through dw_mci_enable_sdio_irq > and the handling of the slot specific interrupts in the Interrupt Service > Routine. Please sen

Re: [PATCH v2 1/1] mmc: Support of SDIO irq for dw_mmc

2011-08-24 Thread James Hogan
On 24 August 2011 09:18, Shashidhar Hiremath wrote: > Hi James, >    If I understand your concern correctly, for level triggered > interrupts,the interrupt action needs to taken first,than the > interrupt source needs to be cleared,only then I can clear Raw > Interrupt Status register right ? > >

Re: [PATCH v2 1/1] mmc: Support of SDIO irq for dw_mmc

2011-08-24 Thread Shashidhar Hiremath
Hi James, If I understand your concern correctly, for level triggered interrupts,the interrupt action needs to taken first,than the interrupt source needs to be cleared,only then I can clear Raw Interrupt Status register right ? So ,accordingly ,will the below code be in appropriate order ?

Re: [PATCH v2 1/1] mmc: Support of SDIO irq for dw_mmc

2011-08-23 Thread James Hogan
Hi, On 23 August 2011 14:20, Shashidhar Hiremath wrote: > The Patch adds the support for SDIO interrupts for all slots. > It includes enabling of SDIO interrupts through dw_mci_enable_sdio_irq > and the handling of the slot specific interrupts in the Interrupt Service > Routine. > > Signed-off-by

[PATCH v2 1/1] mmc: Support of SDIO irq for dw_mmc

2011-08-23 Thread Shashidhar Hiremath
The Patch adds the support for SDIO interrupts for all slots. It includes enabling of SDIO interrupts through dw_mci_enable_sdio_irq and the handling of the slot specific interrupts in the Interrupt Service Routine. Signed-off-by: Shashidhar Hiremath --- v2: * As per Suggestions by James Hogan -f