Re: [PATCH v2 10/20] omap: zoom: add fixed regulator device for wlan

2010-07-25 Thread Ohad Ben-Cohen
On Fri, Jul 23, 2010 at 12:15 PM, Mark Brown wrote: > On Fri, Jul 23, 2010 at 02:13:38AM +0300, Ohad Ben-Cohen wrote: >> On Thu, Jul 22, 2010 at 2:16 PM, Roger Quadros >> wrote: >> > .dev_name       = "mmci-omap-hs.2" > >> I already set the .dev member of the consumer in a similar manner to >> h

Re: [PATCH v2 10/20] omap: zoom: add fixed regulator device for wlan

2010-07-23 Thread Mark Brown
On Fri, Jul 23, 2010 at 02:13:38AM +0300, Ohad Ben-Cohen wrote: > On Thu, Jul 22, 2010 at 2:16 PM, Roger Quadros > wrote: > > .dev_name       = "mmci-omap-hs.2" > I already set the .dev member of the consumer in a similar manner to > how all other regulators are configured in this board - please

Re: [PATCH v2 10/20] omap: zoom: add fixed regulator device for wlan

2010-07-22 Thread Ohad Ben-Cohen
On Thu, Jul 22, 2010 at 2:16 PM, Roger Quadros wrote: > On 07/21/2010 08:59 PM, ext Mark Brown wrote: >> >> On Wed, Jul 21, 2010 at 08:33:44PM +0300, Ohad Ben-Cohen wrote: >> >>> +static struct regulator_consumer_supply zoom_vmmc3_supply = { >>> +       .supply         = "vmmc", >>> +}; >> >> This

Re: [PATCH v2 10/20] omap: zoom: add fixed regulator device for wlan

2010-07-22 Thread Roger Quadros
On 07/21/2010 08:59 PM, ext Mark Brown wrote: On Wed, Jul 21, 2010 at 08:33:44PM +0300, Ohad Ben-Cohen wrote: +static struct regulator_consumer_supply zoom_vmmc3_supply = { + .supply = "vmmc", +}; This looks like a misconfiguration on the consumer - I'd strongly expect the consu

Re: [PATCH v2 10/20] omap: zoom: add fixed regulator device for wlan

2010-07-21 Thread Mark Brown
On Wed, Jul 21, 2010 at 08:33:44PM +0300, Ohad Ben-Cohen wrote: > +static struct regulator_consumer_supply zoom_vmmc3_supply = { > + .supply = "vmmc", > +}; This looks like a misconfiguration on the consumer - I'd strongly expect the consumer to have a dev_name specified also with the

[PATCH v2 10/20] omap: zoom: add fixed regulator device for wlan

2010-07-21 Thread Ohad Ben-Cohen
Add a fixed regulator vmmc device to enable power control of the wl1271 wlan device. Signed-off-by: Ohad Ben-Cohen --- arch/arm/mach-omap2/board-zoom-peripherals.c | 34 ++ 1 files changed, 34 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/board-zoom-pe