Re: [PATCH v2 18/26] MMC: Add JZ4740 mmc driver

2010-06-19 Thread Lars-Peter Clausen
Hi Matt Fleming wrote: > On Sat, 19 Jun 2010 07:08:23 +0200, Lars-Peter Clausen wrote: >> This patch adds support for the mmc controller on JZ4740 SoCs. >> > > Hey Lars-Peter, > > I had a quick look over this patch and it looks OK. Just a few comments. > >> +static void jz4740_mmc_timeout(unsigne

Re: [PATCH v2 18/26] MMC: Add JZ4740 mmc driver

2010-06-19 Thread Matt Fleming
On Sat, 19 Jun 2010 07:08:23 +0200, Lars-Peter Clausen wrote: > This patch adds support for the mmc controller on JZ4740 SoCs. > Hey Lars-Peter, I had a quick look over this patch and it looks OK. Just a few comments. > +static void jz4740_mmc_timeout(unsigned long data) > +{ > + struct jz

[PATCH v2 18/26] MMC: Add JZ4740 mmc driver

2010-06-18 Thread Lars-Peter Clausen
This patch adds support for the mmc controller on JZ4740 SoCs. Signed-off-by: Lars-Peter Clausen Cc: Andrew Morton Cc: linux-mmc@vger.kernel.org --- Changes since v1 - Do not request IRQ with IRQF_DISABLED since it is a noop now - Use a generous slack for the timeout timer. It does not need to