Re: [PATCH v3] mmc: moxart: fix probe logic

2015-02-03 Thread Arnd Bergmann
On Tuesday 03 February 2015 09:02:22 Ulf Hansson wrote: > > @@ -586,10 +588,11 @@ static int moxart_probe(struct platform_device *pdev) > > goto out; > > } > > > > - clk = of_clk_get(node, 0); > > This code would be simpler using devm_clk_get(), since then error > wou

Re: [PATCH v3] mmc: moxart: fix probe logic

2015-02-03 Thread Ulf Hansson
On 2 February 2015 at 16:43, Jonas Jensen wrote: > Jonas Jensen wanted to submit a patch for these, but apparently > forgot about it. I stumbled over this symptom first: > > drivers/built-in.o: In function `moxart_probe': > :(.text+0x2af128): undefined reference to `of_dma_request_slave_channel' >

Re: [PATCH v3] mmc: moxart: fix probe logic

2015-02-02 Thread Arnd Bergmann
On Monday 02 February 2015 16:43:06 Jonas Jensen wrote: > > Notes: > This is a forward (with a single line fix) of Arnd's v2 patch. > > v2: do not call clk_put() on an error pointer > v3: fix NULL dereference on host->clk > > Applies to next-20150113 Thanks for forward

[PATCH v3] mmc: moxart: fix probe logic

2015-02-02 Thread Jonas Jensen
Jonas Jensen wanted to submit a patch for these, but apparently forgot about it. I stumbled over this symptom first: drivers/built-in.o: In function `moxart_probe': :(.text+0x2af128): undefined reference to `of_dma_request_slave_channel' This is because of_dma_request_slave_channel is an internal