Re: [PATCH v3] mmc-omap: Add support for 16-bit and 32-bit registers

2009-11-23 Thread Cory Maccarrone
On Mon, Nov 23, 2009 at 5:25 AM, Ladislav Michl wrote: [...] >> @@ -167,6 +168,8 @@ struct mmc_omap_host { >>       spinlock_t              clk_lock;     /* for changing enabled state */ >>       unsigned int            fclk_enabled:1; >> >> +     unsigned                reg_shift:1; >> + > [...]

Re: [PATCH v3] mmc-omap: Add support for 16-bit and 32-bit registers

2009-11-23 Thread Alistair Buxton
2009/11/23 Ladislav Michl : > And sorry to ask again. This very driver works reliable and there are no > timeouts like this > mmci-omap mmci-omap.0: command timeout (CMD8) > mmci-omap mmci-omap.0: command timeout (CMD5) > mmci-omap mmci-omap.0: command timeout (CMD5) > mmci-omap mmci-omap.0: comma

Re: [PATCH v3] mmc-omap: Add support for 16-bit and 32-bit registers

2009-11-23 Thread Ladislav Michl
On Sun, Nov 22, 2009 at 01:16:25PM -0800, Cory Maccarrone wrote: > The omap850 and omap730 use 16-bit registers instead of 32-bit, requiring > a modification of the register addresses in the mmc-omap driver. To resolve > this, a bit shift is performed on base register addresses, either by 1 or 2 >

[PATCH v3] mmc-omap: Add support for 16-bit and 32-bit registers

2009-11-22 Thread Cory Maccarrone
The omap850 and omap730 use 16-bit registers instead of 32-bit, requiring a modification of the register addresses in the mmc-omap driver. To resolve this, a bit shift is performed on base register addresses, either by 1 or 2 bits depending on the CPU in use. This yields the correct registers for