Re: [PATCH v3] port ricoh_mmc to pci quirk

2010-01-29 Thread Philip Langdale
On Fri, 29 Jan 2010 15:37:35 +0200 Maxim Levitsky maximlevit...@gmail.com wrote: Here, updated patch with your comments addressed. This is also tested with real MMC card. Actual code gets my thumbs up. This adds some 80 chars lines, but I hope that is ok. It's against the coding style and

Re: [PATCH v3] port ricoh_mmc to pci quirk

2010-01-29 Thread Maxim Levitsky
On Fri, 2010-01-29 at 08:06 -0800, Philip Langdale wrote: On Fri, 29 Jan 2010 15:37:35 +0200 Maxim Levitsky maximlevit...@gmail.com wrote: Here, updated patch with your comments addressed. This is also tested with real MMC card. Actual code gets my thumbs up. This adds some 80

Re: [PATCH v3] port ricoh_mmc to pci quirk

2010-01-29 Thread Philip Langdale
On Sat, 30 Jan 2010 00:10:33 +0200 Maxim Levitsky maximlevit...@gmail.com wrote: Well, I have nothing against this, but, even Linus himself stated that he dislikes broken printk lines. I also noticed that some DECLARE_FIXUP in this file are longer that 80, and since breaking this doesn't