Re: [PATCH v3 06/13] mmc: tmio-mmc: define device-tree bindings

2013-02-14 Thread Guennadi Liakhovetski
On Thu, 14 Feb 2013, Magnus Damm wrote: On Thu, Feb 14, 2013 at 10:59 AM, Simon Horman ho...@verge.net.au wrote: On Thu, Feb 14, 2013 at 10:42:21AM +0900, Magnus Damm wrote: On Thu, Feb 14, 2013 at 12:59 AM, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Thu, 7 Feb 2013, Simon

Re: [PATCH v3 06/13] mmc: tmio-mmc: define device-tree bindings

2013-02-14 Thread Magnus Damm
Hi Guennadi, [Added Laurent to CC] On Thu, Feb 14, 2013 at 5:28 PM, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Thu, 14 Feb 2013, Magnus Damm wrote: On Thu, Feb 14, 2013 at 10:59 AM, Simon Horman ho...@verge.net.au wrote: On Thu, Feb 14, 2013 at 10:42:21AM +0900, Magnus Damm

Re: [PATCH v3 06/13] mmc: tmio-mmc: define device-tree bindings

2013-02-14 Thread Guennadi Liakhovetski
Hi Magnus On Thu, 14 Feb 2013, Magnus Damm wrote: Hi Guennadi, [Added Laurent to CC] On Thu, Feb 14, 2013 at 5:28 PM, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Thu, 14 Feb 2013, Magnus Damm wrote: On Thu, Feb 14, 2013 at 10:59 AM, Simon Horman ho...@verge.net.au wrote:

Re: [PATCH v3 06/13] mmc: tmio-mmc: define device-tree bindings

2013-02-14 Thread Arnd Bergmann
On Thursday 14 February 2013, Guennadi Liakhovetski wrote: On Thu, 14 Feb 2013, Magnus Damm wrote: On Thu, Feb 14, 2013 at 5:28 PM, Guennadi Liakhovetski My take on this is the following: having N optionally available on different IP-versions features, I'd rather have N DT properties,

Re: [PATCH v3 06/13] mmc: tmio-mmc: define device-tree bindings

2013-02-13 Thread Guennadi Liakhovetski
On Thu, 7 Feb 2013, Simon Horman wrote: On Wed, Feb 06, 2013 at 10:24:20PM +, Arnd Bergmann wrote: On Wednesday 06 February 2013, Guennadi Liakhovetski wrote: +* Toshiba Mobile IO SD/MMC controller + +The tmio-mmc driver doesn't probe its devices actively, instead its binding

Re: [PATCH v3 06/13] mmc: tmio-mmc: define device-tree bindings

2013-02-13 Thread Magnus Damm
On Thu, Feb 14, 2013 at 12:59 AM, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Thu, 7 Feb 2013, Simon Horman wrote: On Wed, Feb 06, 2013 at 10:24:20PM +, Arnd Bergmann wrote: On Wednesday 06 February 2013, Guennadi Liakhovetski wrote: +* Toshiba Mobile IO SD/MMC controller

Re: [PATCH v3 06/13] mmc: tmio-mmc: define device-tree bindings

2013-02-13 Thread Simon Horman
On Thu, Feb 14, 2013 at 10:42:21AM +0900, Magnus Damm wrote: On Thu, Feb 14, 2013 at 12:59 AM, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Thu, 7 Feb 2013, Simon Horman wrote: On Wed, Feb 06, 2013 at 10:24:20PM +, Arnd Bergmann wrote: On Wednesday 06 February 2013,

Re: [PATCH v3 06/13] mmc: tmio-mmc: define device-tree bindings

2013-02-13 Thread Magnus Damm
On Thu, Feb 14, 2013 at 10:59 AM, Simon Horman ho...@verge.net.au wrote: On Thu, Feb 14, 2013 at 10:42:21AM +0900, Magnus Damm wrote: On Thu, Feb 14, 2013 at 12:59 AM, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Thu, 7 Feb 2013, Simon Horman wrote: On Wed, Feb 06, 2013 at

Re: [PATCH v3 06/13] mmc: tmio-mmc: define device-tree bindings

2013-02-13 Thread Simon Horman
On Thu, Feb 14, 2013 at 11:09:06AM +0900, Magnus Damm wrote: On Thu, Feb 14, 2013 at 10:59 AM, Simon Horman ho...@verge.net.au wrote: On Thu, Feb 14, 2013 at 10:42:21AM +0900, Magnus Damm wrote: On Thu, Feb 14, 2013 at 12:59 AM, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Thu,

Re: [PATCH v3 06/13] mmc: tmio-mmc: define device-tree bindings

2013-02-07 Thread Arnd Bergmann
On Thursday 07 February 2013, Simon Horman wrote: Please write the binding in a way that does not refer to a specific implementation in Linux: The binding should describe the hardware independent of details in the driver. In particular, I think you should not refer to the

[PATCH v3 06/13] mmc: tmio-mmc: define device-tree bindings

2013-02-06 Thread Guennadi Liakhovetski
Define device-tree bindings for the tmio-mmc driver to be able to specify parameters, currently provided in platform data. Cc: Arnd Bergmann a...@arndb.de Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- v3: make the property to set TMIO_MMC_SDIO_IRQ global

Re: [PATCH v3 06/13] mmc: tmio-mmc: define device-tree bindings

2013-02-06 Thread Arnd Bergmann
On Wednesday 06 February 2013, Guennadi Liakhovetski wrote: +* Toshiba Mobile IO SD/MMC controller + +The tmio-mmc driver doesn't probe its devices actively, instead its binding to +devices is managed by either MFD drivers or by the sh_mobile_sdhi platform +driver. Those drivers supply the

Re: [PATCH v3 06/13] mmc: tmio-mmc: define device-tree bindings

2013-02-06 Thread Simon Horman
On Wed, Feb 06, 2013 at 10:24:20PM +, Arnd Bergmann wrote: On Wednesday 06 February 2013, Guennadi Liakhovetski wrote: +* Toshiba Mobile IO SD/MMC controller + +The tmio-mmc driver doesn't probe its devices actively, instead its binding to +devices is managed by either MFD drivers