You means that didn't run start_host() before add_host failed.
I think that need not to run stop_host. right?
Right, and other stuff like registering the pm_notifier.
To use mmc_free_host, better than mmc_remove_host.
That would be true for most drivers. However, sdhci has encapsulated this
Sometimes we can't add the device,but we didn't check any error status.
Need to check error status for mmc_add_host.
And Missing regulator disable/put. Fixed them.
[PATCH v4] : merged for v3 [PATCH 1/2] and [PATCH 2/2] reviewed on Wolfram Sang
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
On Mon, Apr 11, 2011 at 11:11:08AM +0900, Jaehoon Chung wrote:
Sometimes we can't add the device,but we didn't check any error status.
Need to check error status for mmc_add_host.
And Missing regulator disable/put. Fixed them.
Is there any special reason you don't want to answer the open
Wolfram Sang wrote:
On Mon, Apr 11, 2011 at 11:11:08AM +0900, Jaehoon Chung wrote:
Sometimes we can't add the device,but we didn't check any error status.
Need to check error status for mmc_add_host.
And Missing regulator disable/put. Fixed them.
Is there any special reason you don't want
I just think good that remove the host...(any crash didn't occur).
there is not special reason.
Look at the mmc-core code, please (host.c). Compare what remove_host does and
what add_host does before it fails. What do you think?
Regards,
Wolfram
--
Pengutronix e.K.
Wolfram Sang wrote:
I just think good that remove the host...(any crash didn't occur).
there is not special reason.
Look at the mmc-core code, please (host.c). Compare what remove_host does and
what add_host does before it fails. What do you think?
Ok..i'm looking at the mmc-core
