Re: [PATCH v4] mmc-omap: Add support for 16-bit and 32-bit registers

2009-11-23 Thread Cory Maccarrone
On Mon, Nov 23, 2009 at 11:12 AM, Ladislav Michl wrote: > Ah, there is no valid reason to make it bitfield, right? Whole struct is > not well layed wtr alignment, but please do not make it any worse. That is > my last complain, I swear ;-). Thank you for your patience. > > Other than that, tested

Re: [PATCH v4] mmc-omap: Add support for 16-bit and 32-bit registers

2009-11-23 Thread Ladislav Michl
On Mon, Nov 23, 2009 at 08:23:59AM -0800, Cory Maccarrone wrote: > The omap850 and omap730 use 16-bit registers instead of 32-bit, requiring > a modification of the register addresses in the mmc-omap driver. To resolve > this, a bit shift is performed on base register addresses, either by 1 or 2 >

Re: [PATCH v4] mmc-omap: Add support for 16-bit and 32-bit registers

2009-11-23 Thread Tony Lindgren
* Cory Maccarrone [091123 08:23]: > The omap850 and omap730 use 16-bit registers instead of 32-bit, requiring > a modification of the register addresses in the mmc-omap driver. To resolve > this, a bit shift is performed on base register addresses, either by 1 or 2 > bits depending on the CPU in

[PATCH v4] mmc-omap: Add support for 16-bit and 32-bit registers

2009-11-23 Thread Cory Maccarrone
The omap850 and omap730 use 16-bit registers instead of 32-bit, requiring a modification of the register addresses in the mmc-omap driver. To resolve this, a bit shift is performed on base register addresses, either by 1 or 2 bits depending on the CPU in use. This yields the correct registers for