Re: [PATCH v4 3/8] wireless: wl1271: add platform driver to get board data

2010-08-12 Thread Ohad Ben-Cohen
On Thu, Aug 12, 2010 at 12:25 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: I've outlined a far simpler and easiler solution which avoids this kind of abuse, and given suggestions on how to extend it to support multiple instances. Do you mean:

Re: [PATCH v4 3/8] wireless: wl1271: add platform driver to get board data

2010-08-12 Thread Ohad Ben-Cohen
On Thursday, August 12, 2010, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Thu, Aug 12, 2010 at 09:40:19AM +0300, Ohad Ben-Cohen wrote: On Thu, Aug 12, 2010 at 12:25 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: I've outlined a far simpler and easiler solution which

[PATCH v4 3/8] wireless: wl1271: add platform driver to get board data

2010-08-11 Thread Ohad Ben-Cohen
Dynamically create and register a platform driver, that will be used to to receive board-specific information like irq and reference clock numbers. The driver is created dynamically in order to avoid the 1-device limitation of a fixed platform driver name. Signed-off-by: Ohad Ben-Cohen

RE: [PATCH v4 3/8] wireless: wl1271: add platform driver to get board data

2010-08-11 Thread DebBarma, Tarun Kanti
...@lists.infradead.org; Chikkature Rajashekar, Madhusudhan; Coelho Luciano (Nokia-MS/Helsinki); a...@linux-foundation.org; San Mehat; Quadros Roger (Nokia-MS/Helsinki); Tony Lindgren; Nicolas Pitre; Pandita, Vikram; Kalle Valo Subject: Re: [PATCH v4 3/8] wireless: wl1271: add platform driver

Re: [PATCH v4 3/8] wireless: wl1271: add platform driver to get board data

2010-08-11 Thread Felipe Balbi
Hi, On Wed, Aug 11, 2010 at 08:52:54PM +0200, ext DebBarma, Tarun Kanti wrote: True; however if we go by that argument than we can also assume pdata is valid, so that we would not need the below check. of course not. You can have devices that just play well with default values or devices

Re: [PATCH v4 3/8] wireless: wl1271: add platform driver to get board data

2010-08-11 Thread Russell King - ARM Linux
On Thu, Aug 12, 2010 at 12:22:54AM +0530, DebBarma, Tarun Kanti wrote: True; however if we go by that argument than we can also assume pdata is valid, so that we would not need the below check. If pdev was ever NULL in a probe function, the kernel deserves to OOPS so that you have a backtrace

Re: [PATCH v4 3/8] wireless: wl1271: add platform driver to get board data

2010-08-11 Thread Vitaly Wool
Hi Ohad, On Wed, Aug 11, 2010 at 10:10 PM, Ohad Ben-Cohen o...@wizery.com wrote: Think of several wl1271 devices, each of which is represented by two devices; an SDIO function, and a platform device. The SDIO function stands for a specific MMC controller the device is hardwired to, and the

Re: [PATCH v4 3/8] wireless: wl1271: add platform driver to get board data

2010-08-11 Thread Ohad Ben-Cohen
Hi Vitaly, On Thu, Aug 12, 2010 at 12:34 AM, Vitaly Wool vitalyw...@gmail.com wrote: On Wed, Aug 11, 2010 at 10:10 PM, Ohad Ben-Cohen o...@wizery.com wrote: Think of several wl1271 devices, each of which is represented by two devices; an SDIO function, and a platform device. The SDIO function

Re: [PATCH v4 3/8] wireless: wl1271: add platform driver to get board data

2010-08-11 Thread Felipe Balbi
Hi, On Wed, Aug 11, 2010 at 10:10:38PM +0200, ext Ohad Ben-Cohen wrote: Think of several wl1271 devices, each of which is represented by two devices; an SDIO function, and a platform device. The SDIO function stands for a specific MMC controller the device is hardwired to, and the platform