Re: [PATCH v4 4/7] ARM: sunxi: Add driver for SD/MMC hosts found on Allwinner sunxi SoCs

2014-02-10 Thread David Lanzendörfer
Hi > > +(cmd->opcode == 5 || cmd->opcode == 52)) > Aren't these the ones defined in linux/mmc/sdio.h: > 5 - SD_IO_SEND_OP_COND > 52 - SD_IO_RW_DIRECT Yes. They are... Changed that. Also I removed the camel cases and the defines within the struct definition. > > +struct sunxi_mmc_clk_d

[PATCH v4 4/7] ARM: sunxi: Add driver for SD/MMC hosts found on Allwinner sunxi SoCs

2014-02-07 Thread David Lanzendörfer
This is based on the driver Allwinner ships in their Android kernel sources. Initial porting to upstream kernels done by David Lanzendörfer, additional fixes and cleanups by Hans de Goede. It uses dma in bus-master mode using a built-in designware idmac controller, which is identical to the one f