* Vitaly Wool [100915 01:18]:
> 2010/9/15 Ohad Ben-Cohen :
> >> Sorry for pushing at this, but why would you mark data that's meant to
> >> be used after init phase as __initdata?
> >
> > I can remove the first copying as well if Russell is ok with it.
>
> I personally think it's not worth it. Th
W dniu 15 września 2010 10:25 użytkownik Russell King - ARM Linux
napisał:
> On Mon, Sep 06, 2010 at 09:42:41PM +0200, Michał Mirosław wrote:
>> W dniu 6 września 2010 14:07 użytkownik Russell King - ARM Linux
>> napisał:
>> > On Sat, Sep 04, 2010 at 02:23:19PM +0200, Michał Mirosław wrote:
>> >>
2010/9/15 Ohad Ben-Cohen :
>> Sorry for pushing at this, but why would you mark data that's meant to
>> be used after init phase as __initdata?
>
> I can remove the first copying as well if Russell is ok with it.
I personally think it's not worth it. This copying basically happens
only once and th
On Mon, Sep 06, 2010 at 09:42:41PM +0200, Michał Mirosław wrote:
> W dniu 6 września 2010 14:07 użytkownik Russell King - ARM Linux
> napisał:
> > On Sat, Sep 04, 2010 at 02:23:19PM +0200, Michał Mirosław wrote:
> >> 2010/9/1 Ohad Ben-Cohen :
> >> > Add a simple mechanism to pass platform data to
2010/9/6 Michał Mirosław :
> W dniu 6 września 2010 14:07 użytkownik Russell King - ARM Linux
> napisał:
>> On Sat, Sep 04, 2010 at 02:23:19PM +0200, Michał Mirosław wrote:
>>> 2010/9/1 Ohad Ben-Cohen :
>>> > Add a simple mechanism to pass platform data to the
>>> > SDIO instances of wl12xx.
> [cu
W dniu 6 września 2010 14:07 użytkownik Russell King - ARM Linux
napisał:
> On Sat, Sep 04, 2010 at 02:23:19PM +0200, Michał Mirosław wrote:
>> 2010/9/1 Ohad Ben-Cohen :
>> > Add a simple mechanism to pass platform data to the
>> > SDIO instances of wl12xx.
[cut patch]
>> Why do you need all that
2010/9/6 Russell King - ARM Linux :
> We could instead make wl12xx_get_platform_data() return a const pointer
> to its own internal storage instead, or ERR pointers for the various
> failure cases.
Sounds good:
diff --git a/drivers/net/wireless/wl12xx/wl12xx_platform_data.c
b/drivers/net/wireless
On Sat, Sep 04, 2010 at 02:23:19PM +0200, Michał Mirosław wrote:
> 2010/9/1 Ohad Ben-Cohen :
> > Add a simple mechanism to pass platform data to the
> > SDIO instances of wl12xx.
> >
> > This way there is no confusion over who owns the 'embedded data',
> > typechecking is preserved, and no possibil
2010/9/4 Michał Mirosław :
> 2010/9/1 Ohad Ben-Cohen :
>> Add a simple mechanism to pass platform data to the
>> SDIO instances of wl12xx.
>>
>> This way there is no confusion over who owns the 'embedded data',
>> typechecking is preserved, and no possibility for the wrong driver to
>> pick up the
2010/9/1 Ohad Ben-Cohen :
> Add a simple mechanism to pass platform data to the
> SDIO instances of wl12xx.
>
> This way there is no confusion over who owns the 'embedded data',
> typechecking is preserved, and no possibility for the wrong driver to
> pick up the data.
>
> Originally proposed by Ru
Add a simple mechanism to pass platform data to the
SDIO instances of wl12xx.
This way there is no confusion over who owns the 'embedded data',
typechecking is preserved, and no possibility for the wrong driver to
pick up the data.
Originally proposed by Russell King.
Signed-off-by: Ohad Ben-Coh
11 matches
Mail list logo
